From: Tejun Heo <tj@kernel.org>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Borislav Petkov <bp@alien8.de>, X86-ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>
Subject: Re: [PATCH 5/5] x86: Move enabling of PSE and PGE out of init_memory_mapping
Date: Tue, 14 Aug 2012 13:20:40 -0700 [thread overview]
Message-ID: <20120814202040.GB25632@google.com> (raw)
In-Reply-To: <20120814195247.GA32453@jshin-Toonie>
Hello,
On Tue, Aug 14, 2012 at 02:52:48PM -0500, Jacob Shin wrote:
> > You mean pagetable_reserve() right?
>
> This is actually needed on every call to init_memory_mapping(),
>
> My patch 2/5 changes find_early_table_space() to find just enough space
> to map start to end. The pagetable_reserve() will then reserve what we
> actually used. Since init_memory_mapping() is called again and again
> with different start to end ranges, we find space for the page tables
> and reserve them every time.
I thought the function was rebuilding pagetable for the whole memory
area each time. Maybe I misread. Does it only build the part which
is newly being mapped?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-08-14 20:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 21:23 [PATCH 0/5] Only create direct mappings for E820_RAM regions Jacob Shin
2012-08-09 21:23 ` [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM Jacob Shin
2012-08-09 22:03 ` Yinghai Lu
2012-08-11 18:36 ` H. Peter Anvin
2012-08-13 14:11 ` Jacob Shin
2012-08-11 19:49 ` Tejun Heo
2012-08-13 14:31 ` Jacob Shin
2012-08-09 21:23 ` [PATCH 2/5] x86: find_early_table_space based on memory ranges that are being mapped Jacob Shin
2012-08-11 19:56 ` Tejun Heo
2012-08-09 21:23 ` [PATCH 3/5] x86: Keep track of direct mapped pfn ranges Jacob Shin
2012-08-11 19:57 ` Tejun Heo
2012-08-09 21:23 ` [PATCH 4/5] x86: Fixup code testing if a pfn is direct mapped Jacob Shin
2012-08-09 21:23 ` [PATCH 5/5] x86: Move enabling of PSE and PGE out of init_memory_mapping Jacob Shin
2012-08-11 20:01 ` Tejun Heo
2012-08-13 7:34 ` Borislav Petkov
2012-08-13 23:20 ` Tejun Heo
2012-08-14 8:49 ` Borislav Petkov
2012-08-14 19:52 ` Jacob Shin
2012-08-14 20:20 ` Tejun Heo [this message]
2012-08-11 19:51 ` [PATCH 0/5] Only create direct mappings for E820_RAM regions Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-08-13 21:46 [PATCH V2 0/5] x86: Create direct mappings for E820_RAM only Jacob Shin
2012-08-13 21:47 ` [PATCH 5/5] x86: Move enabling of PSE and PGE out of init_memory_mapping Jacob Shin
2012-08-13 23:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814202040.GB25632@google.com \
--to=tj@kernel.org \
--cc=andreas.herrmann3@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).