From: Jan Kara <jack@suse.cz>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: lkml <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: Bug in UDF, setting larger file size when data in ICB
Date: Wed, 15 Aug 2012 00:22:38 +0200 [thread overview]
Message-ID: <20120814222238.GO7122@quack.suse.cz> (raw)
In-Reply-To: <500D7F39.2000506@mev.co.uk>
On Mon 23-07-12 17:43:37, Ian Abbott wrote:
> On 2012-07-23 16:19, Ian Abbott wrote:
> >Hi folks,
> >
> >in fs/udf/inode.c, udf_setsize(), if the new size is larger than the old
> >size and the old data is in the ICB and the new size still fits in the
> >ICB (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB and iinfo->i_lenAlloc
> >= newsize), udf_extend_file() is called which promptly calls BUG()
> >because it does not like this i_alloc_type value.
> >
> >I think the simplest fix would be to add a 'goto' after the assignment
> >to iinfo->i_lenAlloc, bypassing the call to udf_extend_file().
>
> Jan is on vacation until early August, so I submitted my own patch:
>
> Date: Mon, 23 Jul 2012 17:39:29 +0100
> Subject: [PATCH] udf: fix udf_setsize() for file data in ICB
> Message-ID: <1343061569-3629-1-git-send-email-abbotti@mev.co.uk>
Thanks for the patch. I've added it to my tree and will send it to Linus
soon.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2012-08-14 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 15:19 Bug in UDF, setting larger file size when data in ICB Ian Abbott
2012-07-23 16:43 ` Ian Abbott
2012-08-14 22:22 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814222238.GO7122@quack.suse.cz \
--to=jack@suse.cz \
--cc=abbotti@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox