From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752235Ab2HOGlN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Aug 2012 02:41:13 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:57885 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751251Ab2HOGlM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Aug 2012 02:41:12 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: wei_wang@realsil.com.cn
Subject: Re: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver
Date: Wed, 15 Aug 2012 06:40:54 +0000
User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; )
Cc: gregkh@linuxfoundation.org, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
        cjb@laptop.org, sameo@linux.intel.com, bp@alien8.de,
        Tejun Heo <tj@kernel.org>
References: <cover.1344939464.git.wei_wang@realsil.com.cn> <81fef7d4f337f6d8e3365752bbb3ef87302b82a0.1344939464.git.wei_wang@realsil.com.cn>
In-Reply-To: <81fef7d4f337f6d8e3365752bbb3ef87302b82a0.1344939464.git.wei_wang@realsil.com.cn>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201208150640.54561.arnd@arndb.de>
X-Provags-ID: V02:K0:dfn5ImY9T808YPMLFSqVDKOwHUv0lFns12wqgyDASM5
 MWNEXFsRgUHh29NQvuvytXa0ae/v/eNLT99/Slq7XrDZ/vdHeu
 ULiIDFqgENY+vcnjSUQLZpwmRlVsCf9Cwte60TAzNDZFtazw5M
 b/JV2bT8OtR2auz0R1DkvZO7umYADdNaRzjbMJ616CJM4SRMk2
 UC3aCtAe/OgxUZnHg/QguAXG6G8y0ZONy2iHgdiNcU+kzmdlFR
 xc+5c8BBx1XutSCkMvuHTUO2tY828h634rul4nZFxTQJZqK2c3
 d5eLwPNMjAQGlUBoQ5zL2R06f/CvvpAjgR4uv9pbY85ssuEslo
 TEL5vg1esuPYO2ELHP4c=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 14 August 2012, wei_wang@realsil.com.cn wrote:
> +
> +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
> +{
> +       /* If pci device removed, don't queue idle work any more */
> +       if (pcr->remove_pci)
> +               return;
> +
> +       if (pcr->state != PDEV_STAT_RUN) {
> +               pcr->state = PDEV_STAT_RUN;
> +               pcr->ops->enable_auto_blink(pcr);
> +       }
> +
> +       mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
> +}
> +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);

One more comment on the mod_timer/queue_work combination: I just saw that
Tejun Heo posted a series to introduce a new mod_delayed_work() helper.

Once that goes in, it would be best to start using it here.

	Arnd