Re: [PATCH v8 0/6] kvm: level irqfd support

Avi Kivity
2012-08-16T18:22:27Z

On 08/16/2012 07:54 PM, Michael S. Tsirkin wrote:
> On Thu, Aug 16, 2012 at 07:39:35PM +0300, Avi Kivity wrote:
>> On 08/16/2012 07:36 PM, Michael S. Tsirkin wrote:
>>
>> >> What if a level irqfd shares a line with a KVM_IRQ_LINE ioctl? Then an
>> >> EOI can de-assert the irqfd source, but the line is kept high by the
>> >> last KVM_IRQ_LINE invocation.
>> >
>> > Exactly. So 1 ID for userspace and 1 for irqfd.
>>
>> Gaa, this mess belongs in userspace.
>
> Not sure I understand what you refer to.
>
> I meant simply
> #define KVM_IRQFD_IRQ_SOURCE_ID 1
> request it at kvm init.
>
> As opposed to using KVM_USERSPACE_IRQ_SOURCE_ID like we do now
> for edge.
> Does this seem acceptable to you?

I meant the pic/ioapic, not this particular bit.

--
error compiling committee.c: too many arguments to function