Re: [PATCH] perf: Let O= makes handle relative paths

Arnaldo Carvalho de Melo
2012-08-13T18:03:03Z

Em Mon, Aug 13, 2012 at 04:29:09PM +0200, Borislav Petkov escreveu:
> On Mon, Aug 13, 2012 at 10:23:02AM -0400, Steven Rostedt wrote:
> > On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote:
> >
> > > So wouldn't it make sense to call this ABSOLUTE_O or so then?
> >
> > That's just because you're russian, and are promoting Vodka! ;-)

Before:

[acme@sandy linux]$ rm -rf ../build/perf
[acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind O=/home/acme/git/build/perf install
/bin/sh: line 0: cd: /home/acme/git/build/perf/: No such file or directory
make: Entering directory `/home/git/linux/tools/perf'
../scripts/Makefile.include:9: *** output directory "/home/acme/git/build/perf/" does not exist. Stop.
make: Leaving directory `/home/git/linux/tools/perf'
[acme@sandy linux]$

Now:

[acme@sandy linux]$ rm -rf ../build/perf
[acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind O=/home/acme/git/build/perf install
/bin/sh: line 0: cd: /home/acme/git/build/perf: No such file or directory
make: Entering directory `/home/git/linux/tools/perf'
GEN perf-archive
GEN /home/git/linux/tools/perf/python/perf.so
make[1]: Entering directory `/home/git/linux/tools/lib/traceevent'
make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
* new build flags or cross compiler
CC /home/git/linux/tools/perf/perf.o
CC /home/git/linux/tools/perf/builtin-annotate.o
CC /home/git/linux/tools/perf/builtin-bench.o
CC /home/git/linux/tools/perf/bench/sched-messaging.o
CC /home/git/linux/tools/perf/bench/sched-pipe.o

I.e. it should stop if the O= provided directory is not there.

Can you fix this? Avoid vodka while doing it :-P

- Arnaldo