Re: [PATCH] i2c: tegra: Fix ifdefs for suspend mode

Mark Brown
2012-08-18T12:01:45Z

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Sat, Aug 18, 2012 at 09:07:32AM +0200, Wolfram Sang wrote:
> On Mon, Jul 30, 2012 at 07:03:07PM +0530, Laxman Dewangan wrote:
> > CONFIG_PM covers runtime only PM.

> I am a bit confused by this description. CONFIG_PM_RUNTIME covers
> runtime PM, no?

The issue is that CONFIG_PM doesn't actually enable any of the PM
callbacks, it only allows you to enable CONFIG_PM_SLEEP and
CONFIG_PM_RUNTIME. This means that if you use CONFIG_PM to protect your
system sleep callbacks they may end up unreferenced if only runtime PM
is enabled.

Personally I'd rather just uncondtionally enable PM rather than faff
around with all these ifdefs...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]