Force enabled HPET at 0x%lx

Force enabled HPET at 0x%lx

[Fengguang Wu]

Hi,

        [   38.650387] PCI host bridge to bus 0000:00
        [   38.657920] pci_bus 0000:00: Force enabled HPET at 0x%lx
                                                                ~~~

That "0x%lx" message should be emitted by one of the dev_printks in
arch/x86/kernel/quirks.c and I failed to see anything wrong with it:

                dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
                        "0x%lx\n", force_hpet_address);

So why the value of "force_hpet_address" is not printed?

        [   38.657920] busn_res: [bus 00-ff] is inserted under domain [bus 00-ff]
        [   38.658480] pci_bus 0000:00: ^A0root bus resource [bus 00-ff]
        [   38.662411] pci_bus 0000:00: ^A0root bus resource [io  0x0000-0xffff]
        [   38.664639] pci_bus 0000:00: ^A0root bus resource [mem 0x00000000-0xffffffffff]
                                        ~~~

And that ^A0 character also looks strange..

Thanks,
Fengguang

Re: Force enabled HPET at 0x%lx

[Markus Trippelsdorf]

On 2012.08.19 at 22:02 +0800, Fengguang Wu wrote:
> Hi,
> 
>         [   38.650387] PCI host bridge to bus 0000:00
>         [   38.657920] pci_bus 0000:00: Force enabled HPET at 0x%lx
>                                                                 ~~~
> 
> That "0x%lx" message should be emitted by one of the dev_printks in
> arch/x86/kernel/quirks.c and I failed to see anything wrong with it:
> 
>                 dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
>                         "0x%lx\n", force_hpet_address);
> 
> So why the value of "force_hpet_address" is not printed?
> 
>         [   38.657920] busn_res: [bus 00-ff] is inserted under domain [bus 00-ff]
>         [   38.658480] pci_bus 0000:00: ^A0root bus resource [bus 00-ff]
>         [   38.662411] pci_bus 0000:00: ^A0root bus resource [io  0x0000-0xffff]
>         [   38.664639] pci_bus 0000:00: ^A0root bus resource [mem 0x00000000-0xffffffffff]
>                                         ~~~
> 
> And that ^A0 character also looks strange..

http://lkml.org/lkml/2012/8/18/143

Fix:
http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commitdiff;h=ebdc82899ec5ed35af1c79ed6a4eeda69dad9b90

-- 
Markus

Re: Force enabled HPET at 0x%lx

[Fengguang Wu]

On Sun, Aug 19, 2012 at 04:18:24PM +0200, Markus Trippelsdorf wrote:
> On 2012.08.19 at 22:02 +0800, Fengguang Wu wrote:
> > Hi,
> > 
> >         [   38.650387] PCI host bridge to bus 0000:00
> >         [   38.657920] pci_bus 0000:00: Force enabled HPET at 0x%lx
> >                                                                 ~~~
> > 
> > That "0x%lx" message should be emitted by one of the dev_printks in
> > arch/x86/kernel/quirks.c and I failed to see anything wrong with it:
> > 
> >                 dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
> >                         "0x%lx\n", force_hpet_address);
> > 
> > So why the value of "force_hpet_address" is not printed?
> > 
> >         [   38.657920] busn_res: [bus 00-ff] is inserted under domain [bus 00-ff]
> >         [   38.658480] pci_bus 0000:00: ^A0root bus resource [bus 00-ff]
> >         [   38.662411] pci_bus 0000:00: ^A0root bus resource [io  0x0000-0xffff]
> >         [   38.664639] pci_bus 0000:00: ^A0root bus resource [mem 0x00000000-0xffffffffff]
> >                                         ~~~
> > 
> > And that ^A0 character also looks strange..
> 
> http://lkml.org/lkml/2012/8/18/143
> 
> Fix:
> http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commitdiff;h=ebdc82899ec5ed35af1c79ed6a4eeda69dad9b90

Quick hand! Thanks!

Fengguang