From: Thierry Reding <thierry.reding@avionic-design.de>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Bryan Wu <bryan.wu@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions
Date: Mon, 20 Aug 2012 09:31:42 +0200 [thread overview]
Message-ID: <20120820073141.GA27645@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF0939@DQHE02.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On Mon, Aug 20, 2012 at 06:16:41AM +0000, Kim, Milo wrote:
> > > * Rather than having to do the #ifdef here, I think it would be
> > better if
> > > the PWM subsystem provided stub functions for pwm_request,
> > pwm_config,
> > > pwm_enable, pwm_disable and pwm_free that do nothing, so you can in
> > effect
> > > let the compiler optimize away the above code.
> >
> > That's actually on my TODO list, but I think it needs to wait until we
> > have gotten rid of all legacy implementations. The stubs would have to
> > move into the !CONFIG_PWM branch, which will in turn break because the
> > legacy implementations would provide non-inlined duplicates.
> >
> > Thierry
>
> OK, then it's better to wait fixing that first.
>
> Bryan,
> please just ignore this patch.
> I'll resend the patch later.
Maybe we should get this resolved somehow in the meantime. Resolving the
other issues may take another cycle or two, so you may not want to wait
that long.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-20 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 4:02 [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions Kim, Milo
2012-08-20 5:04 ` Thierry Reding
2012-08-20 5:06 ` Thierry Reding
2012-08-20 5:37 ` Arnd Bergmann
2012-08-20 5:58 ` Thierry Reding
2012-08-20 6:16 ` Kim, Milo
2012-08-20 7:31 ` Thierry Reding [this message]
2012-08-20 7:41 ` Kim, Milo
2012-08-20 7:50 ` Thierry Reding
2012-08-20 7:56 ` Kim, Milo
2012-08-20 6:13 ` Kim, Milo
2012-08-20 6:45 ` Arnd Bergmann
2012-08-20 7:26 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820073141.GA27645@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=Milo.Kim@ti.com \
--cc=arnd@arndb.de \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox