From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, Axel Lin <axel.lin@gmail.com>,
Gyungoh Yoo <jack.yoo@maxim-ic.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regulator: max8907: fix compile error when !CONFIG_OF
Date: Mon, 20 Aug 2012 20:57:56 +0100 [thread overview]
Message-ID: <20120820195756.GP26991@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1345477150-25933-1-git-send-email-swarren@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Mon, Aug 20, 2012 at 09:39:10AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Fix the following:
Applied, thanks.
> Note: It's possible that the MAX8907 PMIC is only used with Tegra; there
> certainly is a reference to AP15 (an old Tegra version) in the MAX8907
> documentation. If so, Tegra implies CONFIG_OF, so we could just make
> MAX8907 depend on CONFIG_OF and remove all the ifdefs from the driver.
> That said, I'm not at all sure whether the MAX8907 is Tegra-specific.
I think this would be a step backwards, if it's that hard to make DT
optional we ought to look at the DT infrastructure. Otherwise build
coverage is good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-20 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 15:39 [PATCH] regulator: max8907: fix compile error when !CONFIG_OF Stephen Warren
2012-08-20 19:57 ` Mark Brown [this message]
2012-08-21 1:21 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820195756.GP26991@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=jack.yoo@maxim-ic.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).