public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: tony.luck@intel.com, Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Colin Cross <ccross@android.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] pstore: add missed platform_device_unregister
Date: Mon, 20 Aug 2012 18:40:00 -0700	[thread overview]
Message-ID: <20120821013958.GA27381@lizard> (raw)
In-Reply-To: <CACV3sbKA6pjcjc+Wr-w+JNtzJfrJS=6tcMKgDzWMaZ_AV1NQ3A@mail.gmail.com>

On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Mon, 20 Aug 2012 14:20:01 +0800
> Subject: [PATCH] pstore: add missed platform_device_unregister
> 
> we need unregister platform device when module exit, add it.
> 
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> ---
>  fs/pstore/ram.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 0b311bc..adb218a 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
>  static void __exit ramoops_exit(void)
>  {
>  	platform_driver_unregister(&ramoops_driver);
> +	platform_device_unregister(dummy);
>  	kfree(dummy_data);
>  }
>  module_exit(ramoops_exit);

It looks OK to me. Unless there are objections I'll apply it to
linux-pstore.git.

Thanks!

  reply	other threads:[~2012-08-21  1:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  6:58 [PATCH] pstore: add missed platform_device_unregister Jovi Zhang
2012-08-21  1:40 ` Anton Vorontsov [this message]
2012-08-21 16:19   ` Kees Cook
2012-08-22  2:48     ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120821013958.GA27381@lizard \
    --to=cbouatmailru@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bookjovi@gmail.com \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox