From: Ingo Molnar <mingo@kernel.org>
To: Andrew Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf: create a helper structure perf_event_context
Date: Tue, 21 Aug 2012 11:59:20 +0200 [thread overview]
Message-ID: <20120821095920.GA3241@gmail.com> (raw)
In-Reply-To: <1344957803-2635317-1-git-send-email-avagin@openvz.org>
* Andrew Vagin <avagin@openvz.org> wrote:
> 18 files changed, 222 insertions(+), 255 deletions(-)
> -static int process_sample_event(struct perf_tool *tool,
> - union perf_event *event,
> - struct perf_sample *sample,
> - struct perf_evsel *evsel,
> - struct machine *machine)
> +static int process_sample_event(struct perf_event_context *ectx)
> {
> - struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool);
> + struct perf_sample *sample = ectx->sample;
> + struct perf_annotate *ann = container_of(ectx->tool, struct perf_annotate, tool);
> struct addr_location al;
that looks like a nice cleanliness win.
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2012-08-21 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 15:23 [PATCH] perf: create a helper structure perf_event_context Andrew Vagin
2012-08-21 9:59 ` Ingo Molnar [this message]
2012-08-21 13:14 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821095920.GA3241@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox