From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jovi Zhang <bookjovi@gmail.com>,
tony.luck@intel.com, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH] pstore: add missed platform_device_unregister
Date: Tue, 21 Aug 2012 19:48:29 -0700 [thread overview]
Message-ID: <20120822024829.GA20787@lizard> (raw)
In-Reply-To: <CAGXu5j+KvkQV94D+kT4b5+UcCX1wZz_04STb3H4CmB1Em-fB3g@mail.gmail.com>
On Tue, Aug 21, 2012 at 09:19:15AM -0700, Kees Cook wrote:
[...]
> >> static void __exit ramoops_exit(void)
> >> {
> >> platform_driver_unregister(&ramoops_driver);
> >> + platform_device_unregister(dummy);
> >> kfree(dummy_data);
> >> }
> >> module_exit(ramoops_exit);
> >
> > It looks OK to me. Unless there are objections I'll apply it to
> > linux-pstore.git.
>
> Yup, looks right.
>
> Acked-by: Kees Cook <keescook@chromium.org>
Applied, thanks!
prev parent reply other threads:[~2012-08-22 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 6:58 [PATCH] pstore: add missed platform_device_unregister Jovi Zhang
2012-08-21 1:40 ` Anton Vorontsov
2012-08-21 16:19 ` Kees Cook
2012-08-22 2:48 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822024829.GA20787@lizard \
--to=cbouatmailru@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bookjovi@gmail.com \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox