From: Fengguang Wu <fengguang.wu@intel.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>,
"Kim, Milo" <Milo.Kim@ti.com>
Cc: Axel Lin <axel.lin@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] lp8727_charger: use IRQF_ONESHOT
Date: Thu, 23 Aug 2012 19:42:29 +0800 [thread overview]
Message-ID: <20120823114229.GA16789@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Note: I don't really know much about the situation, feel free to
ignore it if it's an false warning.
cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
return request_threaded_irq(pchg->client->irq,
NULL,
lp8727_isr_func,
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"lp8727_irq",
pchg);
}
[-- Attachment #2: irqf_oneshot-lp8727_charger.patch --]
[-- Type: text/x-diff, Size: 819 bytes --]
[PATCH] lp8727_charger: fix coccinelle warnings
/c/kernel-tests/src/linux/drivers/power/lp8727_charger.c:255:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
return request_threaded_irq(pchg->client->irq,
NULL,
lp8727_isr_func,
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"lp8727_irq",
pchg);
}
next reply other threads:[~2012-08-23 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 11:42 Fengguang Wu [this message]
2012-08-23 11:56 ` [PATCH] twl4030_charger: use IRQF_ONESHOT Fengguang Wu
2012-08-23 12:00 ` Felipe Balbi
2012-09-20 22:43 ` Anton Vorontsov
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
2012-09-20 22:44 ` Anton Vorontsov
2012-08-30 11:41 ` Kim, Milo
2012-08-30 12:06 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823114229.GA16789@localhost \
--to=fengguang.wu@intel.com \
--cc=Milo.Kim@ti.com \
--cc=anton.vorontsov@linaro.org \
--cc=axel.lin@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox