From: Fengguang Wu <fengguang.wu@intel.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>, NeilBrown <neilb@suse.de>
Subject: [PATCH] twl4030_charger: use IRQF_ONESHOT
Date: Thu, 23 Aug 2012 19:56:43 +0800 [thread overview]
Message-ID: <20120823115643.GA17927@localhost> (raw)
In-Reply-To: <20120823114229.GA16789@localhost>
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
drivers/power/twl4030_charger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800
+++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800
@@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
}
ret = request_threaded_irq(bci->irq_chg, NULL,
- twl4030_charger_interrupt, 0, pdev->name, bci);
+ twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
if (ret < 0) {
dev_err(&pdev->dev, "could not request irq %d, status %d\n",
bci->irq_chg, ret);
@@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
}
ret = request_threaded_irq(bci->irq_bci, NULL,
- twl4030_bci_interrupt, 0, pdev->name, bci);
+ twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
if (ret < 0) {
dev_err(&pdev->dev, "could not request irq %d, status %d\n",
bci->irq_bci, ret);
next prev parent reply other threads:[~2012-08-23 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 11:42 [PATCH] lp8727_charger: use IRQF_ONESHOT Fengguang Wu
2012-08-23 11:56 ` Fengguang Wu [this message]
2012-08-23 12:00 ` [PATCH] twl4030_charger: " Felipe Balbi
2012-09-20 22:43 ` Anton Vorontsov
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
2012-09-20 22:44 ` Anton Vorontsov
2012-08-30 11:41 ` Kim, Milo
2012-08-30 12:06 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823115643.GA17927@localhost \
--to=fengguang.wu@intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=dwmw2@infradead.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox