* [PATCH] lp8727_charger: use IRQF_ONESHOT
@ 2012-08-23 11:42 Fengguang Wu
2012-08-23 11:56 ` [PATCH] twl4030_charger: " Fengguang Wu
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Fengguang Wu @ 2012-08-23 11:42 UTC (permalink / raw)
To: Anton Vorontsov, Kim, Milo; +Cc: Axel Lin, David Woodhouse, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Note: I don't really know much about the situation, feel free to
ignore it if it's an false warning.
cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
return request_threaded_irq(pchg->client->irq,
NULL,
lp8727_isr_func,
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"lp8727_irq",
pchg);
}
[-- Attachment #2: irqf_oneshot-lp8727_charger.patch --]
[-- Type: text/x-diff, Size: 819 bytes --]
[PATCH] lp8727_charger: fix coccinelle warnings
/c/kernel-tests/src/linux/drivers/power/lp8727_charger.c:255:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
return request_threaded_irq(pchg->client->irq,
NULL,
lp8727_isr_func,
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"lp8727_irq",
pchg);
}
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] twl4030_charger: use IRQF_ONESHOT
2012-08-23 11:42 [PATCH] lp8727_charger: use IRQF_ONESHOT Fengguang Wu
@ 2012-08-23 11:56 ` Fengguang Wu
2012-08-23 12:00 ` Felipe Balbi
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
2012-08-30 11:41 ` Kim, Milo
2 siblings, 1 reply; 8+ messages in thread
From: Fengguang Wu @ 2012-08-23 11:56 UTC (permalink / raw)
To: Anton Vorontsov
Cc: David Woodhouse, linux-kernel, Kishon Vijay Abraham I, NeilBrown
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
drivers/power/twl4030_charger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800
+++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800
@@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
}
ret = request_threaded_irq(bci->irq_chg, NULL,
- twl4030_charger_interrupt, 0, pdev->name, bci);
+ twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
if (ret < 0) {
dev_err(&pdev->dev, "could not request irq %d, status %d\n",
bci->irq_chg, ret);
@@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
}
ret = request_threaded_irq(bci->irq_bci, NULL,
- twl4030_bci_interrupt, 0, pdev->name, bci);
+ twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
if (ret < 0) {
dev_err(&pdev->dev, "could not request irq %d, status %d\n",
bci->irq_bci, ret);
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] twl4030_charger: use IRQF_ONESHOT
2012-08-23 11:56 ` [PATCH] twl4030_charger: " Fengguang Wu
@ 2012-08-23 12:00 ` Felipe Balbi
2012-09-20 22:43 ` Anton Vorontsov
0 siblings, 1 reply; 8+ messages in thread
From: Felipe Balbi @ 2012-08-23 12:00 UTC (permalink / raw)
To: Fengguang Wu
Cc: Anton Vorontsov, David Woodhouse, linux-kernel,
Kishon Vijay Abraham I, NeilBrown
[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]
On Thu, Aug 23, 2012 at 07:56:43PM +0800, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
makes sense, NULL hardirq handler:
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/power/twl4030_charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800
> +++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800
> @@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
> }
>
> ret = request_threaded_irq(bci->irq_chg, NULL,
> - twl4030_charger_interrupt, 0, pdev->name, bci);
> + twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
> if (ret < 0) {
> dev_err(&pdev->dev, "could not request irq %d, status %d\n",
> bci->irq_chg, ret);
> @@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
> }
>
> ret = request_threaded_irq(bci->irq_bci, NULL,
> - twl4030_bci_interrupt, 0, pdev->name, bci);
> + twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
> if (ret < 0) {
> dev_err(&pdev->dev, "could not request irq %d, status %d\n",
> bci->irq_bci, ret);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] twl4030_charger: use IRQF_ONESHOT
2012-08-23 12:00 ` Felipe Balbi
@ 2012-09-20 22:43 ` Anton Vorontsov
0 siblings, 0 replies; 8+ messages in thread
From: Anton Vorontsov @ 2012-09-20 22:43 UTC (permalink / raw)
To: Felipe Balbi
Cc: Fengguang Wu, David Woodhouse, linux-kernel,
Kishon Vijay Abraham I, NeilBrown
On Thu, Aug 23, 2012 at 03:00:38PM +0300, Felipe Balbi wrote:
> On Thu, Aug 23, 2012 at 07:56:43PM +0800, Fengguang Wu wrote:
> > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> >
> > Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> makes sense, NULL hardirq handler:
Acks per irq handler is something new to me. :-)
> Acked-by: Felipe Balbi <balbi@ti.com>
Thank you folks, this is now applied!
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] lp8727_charger: use IRQF_ONESHOT
2012-08-23 11:42 [PATCH] lp8727_charger: use IRQF_ONESHOT Fengguang Wu
2012-08-23 11:56 ` [PATCH] twl4030_charger: " Fengguang Wu
@ 2012-08-29 2:00 ` Kim, Milo
2012-09-20 22:44 ` Anton Vorontsov
2012-08-30 11:41 ` Kim, Milo
2 siblings, 1 reply; 8+ messages in thread
From: Kim, Milo @ 2012-08-29 2:00 UTC (permalink / raw)
To: Fengguang Wu
Cc: Anton Vorontsov, Anton Vorontsov, Axel Lin, David Woodhouse,
linux-kernel@vger.kernel.org
> ERROR: Threaded IRQ with no primary handler requested without
> IRQF_ONESHOT
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> Note: I don't really know much about the situation, feel free to
> ignore it if it's an false warning.
>
> cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/power/lp8727_charger.c
> +++ b/drivers/power/lp8727_charger.c
> @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
> return request_threaded_irq(pchg->client->irq,
> NULL,
> lp8727_isr_func,
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> "lp8727_irq",
> pchg);
> }
Thanks for the update.
Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Best Regards,
Milo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] lp8727_charger: use IRQF_ONESHOT
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
@ 2012-09-20 22:44 ` Anton Vorontsov
0 siblings, 0 replies; 8+ messages in thread
From: Anton Vorontsov @ 2012-09-20 22:44 UTC (permalink / raw)
To: Kim, Milo
Cc: Fengguang Wu, Axel Lin, David Woodhouse,
linux-kernel@vger.kernel.org
On Wed, Aug 29, 2012 at 02:00:43AM +0000, Kim, Milo wrote:
[...]
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
[...]
> > - IRQF_TRIGGER_FALLING,
> > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > "lp8727_irq",
> > pchg);
> > }
> Thanks for the update.
>
> Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] lp8727_charger: use IRQF_ONESHOT
2012-08-23 11:42 [PATCH] lp8727_charger: use IRQF_ONESHOT Fengguang Wu
2012-08-23 11:56 ` [PATCH] twl4030_charger: " Fengguang Wu
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
@ 2012-08-30 11:41 ` Kim, Milo
2012-08-30 12:06 ` Anton Vorontsov
2 siblings, 1 reply; 8+ messages in thread
From: Kim, Milo @ 2012-08-30 11:41 UTC (permalink / raw)
To: Anton Vorontsov
Cc: Anton Vorontsov, Axel Lin, David Woodhouse,
linux-kernel@vger.kernel.org, Fengguang Wu
> > ERROR: Threaded IRQ with no primary handler requested without
> > IRQF_ONESHOT
> >
> > Make sure threaded IRQs without a primary handler are always request
> > with IRQF_ONESHOT
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > Note: I don't really know much about the situation, feel free to
> > ignore it if it's an false warning.
> >
> > cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/power/lp8727_charger.c
> > +++ b/drivers/power/lp8727_charger.c
> > @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
> > return request_threaded_irq(pchg->client->irq,
> > NULL,
> > lp8727_isr_func,
> > - IRQF_TRIGGER_FALLING,
> > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > "lp8727_irq",
> > pchg);
> > }
> Thanks for the update.
>
> Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com>
>
Please refer to the patch below.
[PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
This includes previous Fengguang' patch.
Best Regards,
Milo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] lp8727_charger: use IRQF_ONESHOT
2012-08-30 11:41 ` Kim, Milo
@ 2012-08-30 12:06 ` Anton Vorontsov
0 siblings, 0 replies; 8+ messages in thread
From: Anton Vorontsov @ 2012-08-30 12:06 UTC (permalink / raw)
To: Kim, Milo
Cc: Axel Lin, David Woodhouse, linux-kernel@vger.kernel.org,
Fengguang Wu
On Thu, Aug 30, 2012 at 11:41:54AM +0000, Kim, Milo wrote:
> > > ERROR: Threaded IRQ with no primary handler requested without
> > > IRQF_ONESHOT
> > >
> > > Make sure threaded IRQs without a primary handler are always request
> > > with IRQF_ONESHOT
> > >
> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > > ---
> > >
> > > Note: I don't really know much about the situation, feel free to
> > > ignore it if it's an false warning.
> > >
> > > cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/drivers/power/lp8727_charger.c
> > > +++ b/drivers/power/lp8727_charger.c
> > > @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
> > > return request_threaded_irq(pchg->client->irq,
> > > NULL,
> > > lp8727_isr_func,
> > > - IRQF_TRIGGER_FALLING,
> > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > > "lp8727_irq",
> > > pchg);
> > > }
> > Thanks for the update.
> >
> > Acked-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> >
>
> Please refer to the patch below.
> [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
> This includes previous Fengguang' patch.
Nope, I'll include Fengguang's patch (he posted it first), and then
will try to apply the rest of your cleanups on top of it. If it helps,
your can incorporate the fix in your series, preserving the authorship.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-09-20 22:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 11:42 [PATCH] lp8727_charger: use IRQF_ONESHOT Fengguang Wu
2012-08-23 11:56 ` [PATCH] twl4030_charger: " Fengguang Wu
2012-08-23 12:00 ` Felipe Balbi
2012-09-20 22:43 ` Anton Vorontsov
2012-08-29 2:00 ` [PATCH] lp8727_charger: " Kim, Milo
2012-09-20 22:44 ` Anton Vorontsov
2012-08-30 11:41 ` Kim, Milo
2012-08-30 12:06 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox