From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC 00/13] perf test: Add perf_event_attr tests
Date: Fri, 24 Aug 2012 20:12:11 +0200 [thread overview]
Message-ID: <20120824181211.GA32273@gmail.com> (raw)
In-Reply-To: <20120824130706.GA27708@infradead.org>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Fri, Aug 24, 2012 at 11:00:31AM +0200, Jiri Olsa escreveu:
>
> > tools/perf/util/test-attr.c | 142 ++++++++++++++++++++++++++
> > tools/perf/util/test-attr.py | 272 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/test-attr/base-record | 39 ++++++++
>
> I suggest we move all this to:
>
> tools/perf/tests/attr/
Yes!
I'd even strongly suggest increasing perf test's prominence
within the project: if the tests are quick enough to run we
could run them during the build of perf and warn if perf test
fails in an unexpected way with the new perf binary.
( Running new perf on older kernel should never cause an
unexpected failure and thus a build warning. )
So as people are working on new perf patches, the default build
will run perf test and will catch some errors. As the number of
testcases grows it might catch a wide range of bugs. It will
also help us find regressions sooner, when users/testers build
perf they'll always run perf test as well and report new
warnings/failures.
Thanks,
Ingo
prev parent reply other threads:[~2012-08-24 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 9:00 [RFC 00/13] perf test: Add perf_event_attr tests Jiri Olsa
2012-08-24 9:00 ` [PATCH 01/13] perf test: Add framework for atomated " Jiri Olsa
2012-08-24 9:00 ` [PATCH 02/13] perf test: Add perf_event_attr record basic test Jiri Olsa
2012-08-24 9:00 ` [PATCH 03/13] perf test: Add perf_event_attr record group test Jiri Olsa
2012-08-24 9:00 ` [PATCH 04/13] perf test: Add perf_event_attr record freq test Jiri Olsa
2012-08-24 9:00 ` [PATCH 05/13] perf test: Add perf_event_attr record count test Jiri Olsa
2012-08-24 9:00 ` [PATCH 06/13] perf test: Add perf_event_attr record graph test Jiri Olsa
2012-08-24 9:00 ` [PATCH 07/13] perf test: Add perf_event_attr record period test Jiri Olsa
2012-08-24 9:00 ` [PATCH 08/13] perf test: Add perf_event_attr record no samples test Jiri Olsa
2012-08-24 9:00 ` [PATCH 09/13] perf test: Add perf_event_attr record no-inherit test Jiri Olsa
2012-08-24 9:00 ` [PATCH 10/13] perf test: Add perf_event_attr stat basic test Jiri Olsa
2012-08-24 9:00 ` [PATCH 11/13] perf test: Add perf_event_attr stat no-inherit test Jiri Olsa
2012-08-24 9:00 ` [PATCH 12/13] perf test: Add perf_event_attr stat group test Jiri Olsa
2012-08-24 9:00 ` [PATCH 13/13] perf test: Add attr tests under builtin test command Jiri Olsa
2012-08-24 13:07 ` [RFC 00/13] perf test: Add perf_event_attr tests Arnaldo Carvalho de Melo
2012-08-24 18:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824181211.GA32273@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox