Re: [PATCH] xen: fix logical error in tlb flushing

Jan Beulich
2012-08-24T19:45:40Z

>>> On 24.08.12 at 20:17, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Fri, Aug 24, 2012 at 04:16:39PM +0100, Jan Beulich wrote:
>> >>> On 24.08.12 at 10:55, Alex Shi <alex.shi@intel.com> wrote:
>> > While TLB_FLUSH_ALL gets passed as 'end' argument to
>> > flush_tlb_others(), the Xen code was made to check its 'start'
>> > parameter. That may give a incorrect op.cmd to MMUEXT_INVLPG_MULTI
>> > instead of MMUEXT_TLB_FLUSH_MULTI. Then it causes some page can not
>> > be flushed from TLB.
>> >
>> > This patch fixed this issue.
>> >
>> > Reported-by: Jan Beulich <jbeulich@suse.com>
>> > Signed-off-by: Alex Shi <alex.shi@intel.com>
>>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> How can I reproduce this

I don't know, I spotted this while looking at the code.

> and should this also go to stable@kernel.org?

No, the problem got introduced in 3.6-rc1.

Jan