Re: [PATCH] xen: fix logical error in tlb flushing

Konrad Rzeszutek Wilk
2012-09-05T14:44:38Z

On Wed, Sep 05, 2012 at 05:41:37AM +0000, Ren, Yongjie wrote:
> > -----Original Message-----
> > From: Shi, Alex
> > Sent: Wednesday, September 05, 2012 1:35 PM
> > To: Jan Beulich
> > Cc: Konrad Rzeszutek Wilk; tglx@linutronix.de; mingo@redhat.com;
> > linux-kernel@vger.kernel.org; hpa@zytor.com; Ren, Yongjie
> > Subject: Re: [PATCH] xen: fix logical error in tlb flushing
> >
> > On 08/25/2012 03:45 AM, Jan Beulich wrote:
> >
> > >>>> On 24.08.12 at 20:17, Konrad Rzeszutek Wilk
> > <konrad.wilk@oracle.com> wrote:
> > >> On Fri, Aug 24, 2012 at 04:16:39PM +0100, Jan Beulich wrote:
> > >>>>>> On 24.08.12 at 10:55, Alex Shi <alex.shi@intel.com> wrote:
> > >>>> While TLB_FLUSH_ALL gets passed as 'end' argument to
> > >>>> flush_tlb_others(), the Xen code was made to check its 'start'
> > >>>> parameter. That may give a incorrect op.cmd to
> > MMUEXT_INVLPG_MULTI
> > >>>> instead of MMUEXT_TLB_FLUSH_MULTI. Then it causes some page
> > can not
> > >>>> be flushed from TLB.
> > >>>>
> > >>>> This patch fixed this issue.
> > >>>>
> > >>>> Reported-by: Jan Beulich <jbeulich@suse.com>
> > >>>> Signed-off-by: Alex Shi <alex.shi@intel.com>
> > >>>
> > >>> Acked-by: Jan Beulich <jbeulich@suse.com>
> >
> Tested-by: Yongjie Ren <yongjie.ren@intel.com>
>
> >
> > CC to Yongjie,
> > Could you like to test this patch on PV guest
> >
> Xen Dom0 and a PV guest kernel with this patch can boot up correctly.

OK, applied for v3.6