From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>,
linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES
Date: Mon, 27 Aug 2012 19:44:28 +0200 [thread overview]
Message-ID: <20120827174428.GA438@redhat.com> (raw)
In-Reply-To: <20120819164008.GA25454@redhat.com>
Srikar, this is still waiting for your review ;)
FYI, I created the tree to accumulate the acked patches,
kernel.org:/pub/scm/linux/kernel/git/oleg/misc
Currently it has:
Oleg Nesterov (7):
uprobes: kill uprobes_state->count
uprobes: kill dup_mmap()->uprobe_mmap(), simplify uprobe_mmap/munmap
uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending()
uprobes: do not use -EEXIST in install_breakpoint() paths
uprobes: introduce MMF_HAS_UPROBES
uprobes: fold uprobe_reset_state() into uprobe_dup_mmap()
uprobes: remove "verify" argument from set_orig_insn()
Sebastian Andrzej Siewior (1):
uprobes: remove check for uprobe variable in handle_swbp()
Srikar Dronamraju (1):
uprobes: Remove redundant lock_page/unlock_page
You didn't ack Sebastian's patch, but it looks simple. If you
have any objections please let me know.
On 08/19, Oleg Nesterov wrote:
>
> Hello.
>
> On top of "kill uprobes_state->count, add MMF_HAS_UPROBES"
> series.
>
> Once again, I am not sure we really need this (except 1/3).
> Perhaps we could remove uprobe_munmap() instead and forget
> about the false-positive MMF_HAS_UPROBES's.
>
> OTOH, imho it looks a bit more clean this way. Please comment.
>
> diffstat reports the code bloat, but note that the previous
> series removed more code.
>
> Oleg.
>
> include/linux/sched.h | 3 +-
> kernel/events/uprobes.c | 82 +++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 67 insertions(+), 18 deletions(-)
next prev parent reply other threads:[~2012-08-27 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 16:40 [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES Oleg Nesterov
2012-08-19 16:40 ` [PATCH 1/3] uprobes: uprobes_treelock should not disable irqs Oleg Nesterov
2012-09-14 16:18 ` Srikar Dronamraju
2012-08-19 16:40 ` [PATCH 2/3] uprobes: introduce MMF_RECALC_UPROBES Oleg Nesterov
2012-09-14 16:32 ` Srikar Dronamraju
2012-08-19 16:40 ` [PATCH 3/3] uprobes: teach find_active_uprobe() to clear MMF_HAS_UPROBES Oleg Nesterov
2012-09-14 16:43 ` Srikar Dronamraju
2012-09-15 14:41 ` Oleg Nesterov
2012-08-27 17:44 ` Oleg Nesterov [this message]
2012-08-29 17:54 ` [GIT PULL] (Was: uprobes: teach uprobes to clear MMF_HAS_UPROBES) Oleg Nesterov
2012-08-30 8:18 ` Ingo Molnar
2012-09-14 17:12 ` [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120827174428.GA438@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).