From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754695Ab2H0VD0 (ORCPT ); Mon, 27 Aug 2012 17:03:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582Ab2H0VDY (ORCPT ); Mon, 27 Aug 2012 17:03:24 -0400 Date: Mon, 27 Aug 2012 18:02:10 -0300 From: Marcelo Tosatti To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, Avi Kivity , gleb@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH for-3.6] kvm: fix KVM_GET_MSR for PV EOI Message-ID: <20120827210210.GA6192@amt.cnet> References: <20120826150029.GA11114@redhat.com> <20120827204742.GA5031@amt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120827204742.GA5031@amt.cnet> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2012 at 05:47:42PM -0300, Marcelo Tosatti wrote: > On Sun, Aug 26, 2012 at 06:00:29PM +0300, Michael S. Tsirkin wrote: > > KVM_GET_MSR was missing support for PV EOI, > > which is needed for migration. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Please consider this bugfix patch for 3.6. > > Thanks! > > > > arch/x86/kvm/x86.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 91a5958..ff5e985 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -1993,6 +1993,9 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata) > > case MSR_KVM_STEAL_TIME: > > data = vcpu->arch.st.msr_val; > > break; > > + case MSR_KVM_PV_EOI_EN: > > + data = vcpu->arch.pv_eoi.msr_val; > > + break; > > case MSR_IA32_P5_MC_ADDR: > > case MSR_IA32_P5_MC_TYPE: > > case MSR_IA32_MCG_CAP: > > Should increase KVM_SAVE_MSRS_BEGIN. Already done by e115676e042f4d9268, applied.