From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stephen Warren <swarren@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
vinod.koul@intel.com, djbw@fb.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dma: tegra: add const to of_device_id.data's structure
Date: Tue, 28 Aug 2012 20:38:16 +0200 [thread overview]
Message-ID: <20120828183815.GD28643@pengutronix.de> (raw)
In-Reply-To: <503AF6B6.1010808@nvidia.com>
On Sun, Aug 26, 2012 at 09:25:26PM -0700, Stephen Warren wrote:
> On 08/26/2012 03:14 AM, Laxman Dewangan wrote:
> > The membe "data" of structure of_device_id is changed to const
> > pointer. Hence initializing this with const type data.
> > This will fix the compilation warning like
> > drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' qualifier from
> > pointer target type [enabled by default]
> >
> > This warning came after the change
> > ---------
> > commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> > Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > of: add const to struct *of_device_id.data
> > ---------
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>
> I wonder if this should go through Uwe's branch that made similar
> changes for all other drivers though? Uwe now CC'd.
If you forward/bounce the patch to me I can include it in my branch. I
wonder if I missed this warning while testing. I did test all arm
defconfigs based on 3.6-rc1.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-08-28 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 10:14 [PATCH] dma: tegra: add const to of_device_id.data's structure Laxman Dewangan
2012-08-27 4:25 ` Stephen Warren
2012-08-28 18:38 ` Uwe Kleine-König [this message]
2012-08-28 22:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828183815.GD28643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=djbw@fb.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox