From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
Date: Thu, 30 Aug 2012 05:07:48 -0700 [thread overview]
Message-ID: <20120830120747.GA11289@lizard> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF1CA4@DQHE02.ent.ti.com>
On Thu, Aug 30, 2012 at 11:39:57AM +0000, Kim, Milo wrote:
> (a) add configurable debounce timer in the platform data
> : if it is not defined, default time(270ms) is set.
> (b) use schedule_delay_work() and remove unnecessary workqueue resource
> : for delayed interrupt handling, use the schedule_delay_work()
> (c) add lp8727_release_irq() for clearing the irq
> (c) clear interrupts while loading the driver
It seems to me that all of the issues desire their own separate
patches. A few benefits for this:
- It helps reviewing changes;
- In case of regressions, that would help bisecting a lot, plus we will
not need to revert the whole thing, if we'd have to fall back to
revert.
Thanks,
Anton.
prev parent reply other threads:[~2012-08-30 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:39 [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code Kim, Milo
2012-08-30 12:07 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830120747.GA11289@lizard \
--to=cbouatmailru@gmail.com \
--cc=Milo.Kim@ti.com \
--cc=dwmw2@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox