public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 0/8] lp8727_charger: cleanup code
Date: Thu, 30 Aug 2012 05:15:21 -0700	[thread overview]
Message-ID: <20120830121521.GC11289@lizard> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF1C6B@DQHE02.ent.ti.com>

On Thu, Aug 30, 2012 at 11:37:16AM +0000, Kim, Milo wrote:
> LP8727 driver should be patched for several reasons.
> 
> (a) Need to clean up _probe()/_remove()
> (b) Not secure code when the platform data is NULL
> (c) Interrupt handling
>     Two threads are running for handling one IRQ.
>     One is for the IRQ pin, the other is used for delayed processing.
>     This is unusual and can be enhanced.
> (d) Misuse of mutex code
> (e) Lots of definitions should be fixed
> (f) Others..

Thanks a lot for the cleanups, this is much appreciated! The cleanups
themselves look great, but I'd really like to see them more separated.

Thanks,
Anton.

  reply	other threads:[~2012-08-30 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 11:37 [PATCH 0/8] lp8727_charger: cleanup code Kim, Milo
2012-08-30 12:15 ` Anton Vorontsov [this message]
2012-08-30 22:59   ` Kim, Milo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830121521.GC11289@lizard \
    --to=anton.vorontsov@linaro.org \
    --cc=Milo.Kim@ti.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox