From: Michal Marek <mmarek@suse.cz>
To: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC] kconfig/mconf.c: revision of curses initialization.
Date: Thu, 30 Aug 2012 14:59:12 +0200 [thread overview]
Message-ID: <20120830125912.GA14031@sepie.suse.cz> (raw)
In-Reply-To: <gi628woxo0.fsf@mx10.gouders.net>
On Mon, Aug 06, 2012 at 05:19:43PM +0200, Dirk Gouders wrote:
> Hello,
>
> I noticed that in mconf, initscr() is called twice -- as far as I found
> out since commit d0e1e09568.
>
> In case you see a need to fix that:
>
> I first thought about simply removing the call in init_dialog() in
> util.c but then had the feeling that saving of initial cursor positions
> also perhaps is better done in that function...
>
> Dirk
>
> ------------------------------------------------------------------------
> From 1a4022eedbee6032dea16f67bbe4028a8d3d07a0 Mon Sep 17 00:00:00 2001
> From: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
> Date: Mon, 6 Aug 2012 16:48:23 +0200
> Subject: [PATCH] kconfig/mconf.c: revision of curses initialization.
>
> Since commit d0e1e09568 initscr() is called twice in mconf.
>
> Do it only in init_dialog() in util.c and there also save the
> cursor position for the signal handler in mconf.c.
>
> Signed-off-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Applied to kbuild.git#kconfig, thanks.
Michal
prev parent reply other threads:[~2012-08-30 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 15:19 [RFC] kconfig/mconf.c: revision of curses initialization Dirk Gouders
2012-08-30 12:59 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830125912.GA14031@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=gouders@et.bocholt.fh-gelsenkirchen.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox