From: Andrew Morton <akpm@linux-foundation.org>
To: paul.clements@steeleye.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [RESEND] add discard support to nbd
Date: Thu, 30 Aug 2012 15:03:48 -0700 [thread overview]
Message-ID: <20120830150348.287bfa2f.akpm@linux-foundation.org> (raw)
In-Reply-To: <503e0dde.ssYktQsJ5nYlhlQB%paul.clements@steeleye.com>
On Wed, 29 Aug 2012 08:41:02 -0400
paul.clements@steeleye.com wrote:
> Description: This patch adds discard support to nbd. When the nbd client
> system receives a discard request, this will be passed along to the nbd
> server system, where the nbd-server will respond by performing:
> fallocate(.. FALLOC_FL_PUNCH_HOLE ..)
>
> To punch a hole in the backend storage, which is no longer needed.
>
What happens if the user is running an older server?
I is it possible that because the old server didn't set
NBD_FLAG_SEND_TRIM, the user's screen gets filled with WARN_ONs?
Anyway, please make sure this combination was tested!
next prev parent reply other threads:[~2012-08-30 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 12:41 [PATCH 2/2] [RESEND] add discard support to nbd paul.clements
2012-08-30 22:03 ` Andrew Morton [this message]
2012-08-31 15:24 ` Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830150348.287bfa2f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.clements@steeleye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox