From: Andi Kleen <andi@firstfloor.org>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix memset in NFS zap caches
Date: Mon, 3 Sep 2012 20:47:34 +0200 [thread overview]
Message-ID: <20120903184734.GU16230@one.firstfloor.org> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA908F81A8E@SACEXCMBX04-PRD.hq.netapp.com>
> No, this is a gcc bug.
>
> NFS_COOKIEVERF(inode) resolves to an array, so the current code is
> correct. The above change will cause the 2nd half of the array to remain
> uninitialised...
Are you sure?
include/linux/nfs_fs.h:268:static inline __be32 *NFS_COOKIEVERF(const struct inode *inode)
That doesn't look like an array type to me.
-Andi
next prev parent reply other threads:[~2012-09-03 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 18:35 [PATCH] Fix memset in NFS zap caches Andi Kleen
2012-09-03 18:39 ` Myklebust, Trond
2012-09-03 18:47 ` Andi Kleen [this message]
2012-09-03 18:52 ` Myklebust, Trond
[not found] ` <1346698368.3648.6.camel@lade.trondhjem.org>
2012-09-03 19:02 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903184734.GU16230@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox