From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756730Ab2IDJgI (ORCPT ); Tue, 4 Sep 2012 05:36:08 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:35314 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756576Ab2IDJgG (ORCPT ); Tue, 4 Sep 2012 05:36:06 -0400 Date: Tue, 4 Sep 2012 10:36:01 +0100 From: Lee Jones To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de Subject: Re: [PATCH] ARM: ux500: Provide SMSC911x fixed-regulator when not booting DT Message-ID: <20120904093555.GB6091@gmail.com> References: <1345809612-30992-1-git-send-email-lee.jones@linaro.org> <20120903133333.GE31163@gmail.com> <20120904090846.GA6091@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2012 at 11:29:02AM +0200, Linus Walleij wrote: > On Tue, Sep 4, 2012 at 11:08 AM, Lee Jones wrote: > > On Tue, Sep 04, 2012 at 10:53:32AM +0200, Linus Walleij wrote: > > > >> You forgot to add select REGULATOR_FIXED_VOLTAGE to > >> the MOP500 Kconfig entry, but I added it when applying. > > > > I didn't forget. I intentionally left it out because it's > > unconditionally set in the defconfig. > > Since disabling that from the config breaks compile this means > that you just broke Arnds randconfig builds :-P > > If something *must* be configured for the thing to compile, > so it with select. Ah, I see. Noted, thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog