From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Loic Pallardy <loic.pallardy-ext@stericsson.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.com>,
Loic Pallardy <loic.pallardy@stericsson.com>,
"STEricsson_nomadik_linux" <STEricsson_nomadik_linux@list.st.com>,
Loic Pallardy <loic.pallardy@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
"LT ST-Ericsson" <st-ericsson@lists.linaro.org>
Subject: Re: [PATCH 14/17] mfd: db8500-prcmu: use db8500 legacy services
Date: Wed, 5 Sep 2012 11:01:02 +0000 [thread overview]
Message-ID: <201209051101.02595.arnd@arndb.de> (raw)
In-Reply-To: <1346839153-6465-15-git-send-email-loic.pallardy-ext@stericsson.com>
On Wednesday 05 September 2012, Loic Pallardy wrote:
> This patch exposes db8500 legacy services which are
> now available to support new baseband.
> If different are needed, then services are overloaded.
> This allows to reduce duplicate code between projects.
>
> Signed-off-by: Loic Pallardy <loic.pallardy@stericsson.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mfd/db8500-prcmu.c | 90 +++++++++++++++++++++++-----------------------
> drivers/mfd/dbx500-prcmu.h | 71 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 116 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index 73c98e5..b39441f 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -327,12 +327,12 @@ int db8500_prcmu_set_display_clocks(void)
> return 0;
> }
>
> -static u32 db8500_prcmu_read(unsigned int reg)
> +u32 db8500_prcmu_read(unsigned int reg)
> {
> return readl(_PRCMU_BASE + reg);
> }
If these are common to both db8500 and dbx540, why not put the definitions
into the common dbx500.c file, rather than making dbx540 depend on the
db8500?
Arnd
next prev parent reply other threads:[~2012-09-05 11:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 9:58 [PATCH 00/17] Add ST-Ericsson U9540 support Loic Pallardy
2012-09-05 9:58 ` [PATCH 01/17] arm: ux500: add u9540 pin configuration Loic Pallardy
2012-09-05 9:58 ` [PATCH 02/17] arm: ux500: add ccu9540 board support Loic Pallardy
2012-09-05 10:42 ` Arnd Bergmann
2012-09-05 11:38 ` Loic PALLARDY
2012-09-05 12:08 ` Linus Walleij
2012-09-05 12:11 ` Arnd Bergmann
2012-09-05 12:41 ` [st-ericsson] " Linus Walleij
2012-09-05 9:58 ` [PATCH 03/17] arm: ux500: Create board-specific IRQ init callback Loic Pallardy
2012-09-05 9:59 ` [PATCH 04/17] mfd: dbx500-prcmu: Introduce TCDM mapping struct Loic Pallardy
2012-09-05 9:59 ` [PATCH 05/17] mfd: dbx500-prcmu: Handle TCDM mapping Loic Pallardy
2012-09-05 9:59 ` [PATCH 06/17] arm: ux500: Add u9540 PRCMU TCDM configuration Loic Pallardy
2012-09-05 9:59 ` [PATCH 07/17] mfd: prcmu: configurable tcdm base address Loic Pallardy
2012-09-05 9:59 ` [PATCH 08/17] arm: ux500: update DB internal irq nb Loic Pallardy
2012-09-05 9:59 ` [PATCH 09/17] mfd: prcmu: add db9540 support Loic Pallardy
2012-09-05 9:59 ` [PATCH 10/17] mfd: prcmu: dbx500-prmcu creation Loic Pallardy
2012-09-05 9:59 ` [PATCH 11/17] mfd: pcrmu: create common header file for legacy mailbox Loic Pallardy
2012-09-05 9:59 ` [PATCH 12/17] mfd: prcmu: make fw_project_name generic Loic Pallardy
2012-09-05 9:59 ` [PATCH 13/17] mfd: prcmu: make legacy mailbox services configurable Loic Pallardy
2012-09-05 9:59 ` [PATCH 14/17] mfd: db8500-prcmu: use db8500 legacy services Loic Pallardy
2012-09-05 11:01 ` Arnd Bergmann [this message]
2012-09-05 9:59 ` [PATCH 15/17] mfd: dbx540-prcmu creation Loic Pallardy
2012-09-05 12:10 ` Arnd Bergmann
2012-09-05 12:39 ` [st-ericsson] " Linus Walleij
2012-09-05 12:52 ` Arnd Bergmann
2012-09-05 9:59 ` [PATCH 16/17] arm: ux500: add dbx540 prcmu platform data Loic Pallardy
2012-09-05 9:59 ` [PATCH 17/17] mfd: db8500-prcmu: activate dbx540-prcmu driver Loic Pallardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209051101.02595.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy-ext@stericsson.com \
--cc=loic.pallardy@gmail.com \
--cc=loic.pallardy@stericsson.com \
--cc=sameo@linux.intel.com \
--cc=st-ericsson@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox