From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Ren, Yongjie" <yongjie.ren@intel.com>
Cc: "Shi, Alex" <alex.shi@intel.com>, Jan Beulich <JBeulich@suse.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] xen: fix logical error in tlb flushing
Date: Wed, 5 Sep 2012 10:33:50 -0400 [thread overview]
Message-ID: <20120905143350.GD5844@phenom.dumpdata.com> (raw)
In-Reply-To: <1B4B44D9196EFF41AE41FDA404FC0A1018E35D@SHSMSX101.ccr.corp.intel.com>
On Wed, Sep 05, 2012 at 05:41:37AM +0000, Ren, Yongjie wrote:
> > -----Original Message-----
> > From: Shi, Alex
> > Sent: Wednesday, September 05, 2012 1:35 PM
> > To: Jan Beulich
> > Cc: Konrad Rzeszutek Wilk; tglx@linutronix.de; mingo@redhat.com;
> > linux-kernel@vger.kernel.org; hpa@zytor.com; Ren, Yongjie
> > Subject: Re: [PATCH] xen: fix logical error in tlb flushing
> >
> > On 08/25/2012 03:45 AM, Jan Beulich wrote:
> >
> > >>>> On 24.08.12 at 20:17, Konrad Rzeszutek Wilk
> > <konrad.wilk@oracle.com> wrote:
> > >> On Fri, Aug 24, 2012 at 04:16:39PM +0100, Jan Beulich wrote:
> > >>>>>> On 24.08.12 at 10:55, Alex Shi <alex.shi@intel.com> wrote:
> > >>>> While TLB_FLUSH_ALL gets passed as 'end' argument to
> > >>>> flush_tlb_others(), the Xen code was made to check its 'start'
> > >>>> parameter. That may give a incorrect op.cmd to
> > MMUEXT_INVLPG_MULTI
> > >>>> instead of MMUEXT_TLB_FLUSH_MULTI. Then it causes some page
> > can not
> > >>>> be flushed from TLB.
> > >>>>
> > >>>> This patch fixed this issue.
> > >>>>
> > >>>> Reported-by: Jan Beulich <jbeulich@suse.com>
> > >>>> Signed-off-by: Alex Shi <alex.shi@intel.com>
> > >>>
> > >>> Acked-by: Jan Beulich <jbeulich@suse.com>
> >
> Tested-by: Yongjie Ren <yongjie.ren@intel.com>
>
> >
> > CC to Yongjie,
> > Could you like to test this patch on PV guest
> >
> Xen Dom0 and a PV guest kernel with this patch can boot up correctly.
OK, applied for v3.6
next prev parent reply other threads:[~2012-09-05 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 8:55 [PATCH] xen: fix logical error in tlb flushing Alex Shi
2012-08-24 15:16 ` Jan Beulich
2012-08-24 18:17 ` Konrad Rzeszutek Wilk
2012-08-24 19:45 ` Jan Beulich
2012-09-05 5:34 ` Alex Shi
2012-09-05 5:41 ` Ren, Yongjie
2012-09-05 14:33 ` Konrad Rzeszutek Wilk [this message]
2012-09-05 8:04 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905143350.GD5844@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=alex.shi@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox