From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Irina Tirdea <irina.tirdea@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy
Date: Wed, 5 Sep 2012 15:38:49 -0700 [thread overview]
Message-ID: <20120905223849.GF8203@ghostprotocols.net> (raw)
In-Reply-To: <CANg8OWLDxZTrhJ-M2aeLdV-+y0VuGR+3iro179V=LLTeeQi_CA@mail.gmail.com>
Em Wed, Aug 29, 2012 at 01:06:04AM +0300, Irina Tirdea escreveu:
> mempcpy is not supported by bionic in Android
> and will lead to compilation errors.
>
> Replacing mempcpy with memcpy so it will work in Android.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> ---
> tools/perf/util/target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c
> index 051eaa6..065528b 100644
> --- a/tools/perf/util/target.c
> +++ b/tools/perf/util/target.c
> @@ -117,8 +117,8 @@ int perf_target__strerror(struct perf_target *target,
> int errnum,
>
> if (err != buf) {
> size_t len = strlen(err);
> - char *c = mempcpy(buf, err, min(buflen - 1, len));
> - *c = '\0';
> + memcpy(buf, err, min(buflen - 1, len));
> + *(buf + min(buflen - 1, len)) = '\0';
> }
>
Can you resubmit this in txt form? I applied some other patches from you
but you need to try to do it yourself, i.e. send just to you, then try
to save the patch and apply it...
- Arnaldo
next parent reply other threads:[~2012-09-05 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANg8OWLDxZTrhJ-M2aeLdV-+y0VuGR+3iro179V=LLTeeQi_CA@mail.gmail.com>
2012-09-05 22:38 ` Arnaldo Carvalho de Melo [this message]
2012-09-08 0:17 ` [PATCH 11/13] perf tools: replace mempcpy with memcpy Irina Tirdea
2012-08-28 22:22 Irina Tirdea
2012-09-03 1:09 ` Namhyung Kim
2012-09-03 20:59 ` Irina Tirdea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905223849.GF8203@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=irina.tirdea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox