From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774Ab2IFCRi (ORCPT ); Wed, 5 Sep 2012 22:17:38 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:42401 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934Ab2IFCRh (ORCPT ); Wed, 5 Sep 2012 22:17:37 -0400 X-AuditID: 9c93016f-b7cc0ae000000e9f-63-504807bfb35c Date: Thu, 6 Sep 2012 11:19:09 +0900 From: Minchan Kim To: Kamezawa Hiroyuki Cc: Andrew Morton , Yasuaki Ishimatsu , Xishi Qiu , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: use get_page_migratetype instead of page_private Message-ID: <20120906021909.GC31615@bbox> References: <1346829962-31989-1-git-send-email-minchan@kernel.org> <1346829962-31989-2-git-send-email-minchan@kernel.org> <50480447.4030007@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50480447.4030007@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kame, On Thu, Sep 06, 2012 at 11:02:47AM +0900, Kamezawa Hiroyuki wrote: > (2012/09/05 16:26), Minchan Kim wrote: > > page allocator uses set_page_private and page_private for handling > > migratetype when it frees page. Let's replace them with [set|get] > > _page_migratetype to make it more clear. > > > > Signed-off-by: Minchan Kim > > Hmm. one request from me. > > > --- > > include/linux/mm.h | 10 ++++++++++ > > mm/page_alloc.c | 11 +++++++---- > > mm/page_isolation.c | 2 +- > > 3 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 5c76634..86d61d6 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -249,6 +249,16 @@ struct inode; > > #define page_private(page) ((page)->private) > > #define set_page_private(page, v) ((page)->private = (v)) > > > > +static inline void set_page_migratetype(struct page *page, int migratetype) > > +{ > > + set_page_private(page, migratetype); > > +} > > + > > +static inline int get_page_migratetype(struct page *page) > > +{ > > + return page_private(page); > > +} > > + > > Could you add comments to explain "when this function returns expected value" ? > These functions can work well only in very restricted area of codes. Yes. It works only if the page exist in free_list. I will add the comment about that and hope change function name get_page_migratetype with get_buddypage_migratetype. It would be less confusing. Thanks. -- Kind regards, Minchan Kim