From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, fweisbec@gmail.com
Subject: [PATCH] perf: remove sw events from multiplexing rotation list
Date: Thu, 6 Sep 2012 15:23:46 +0200 [thread overview]
Message-ID: <20120906132346.GA32717@quad> (raw)
Software events (sw,tracepoints,...) do not need to be
multiplexed. However, when using a SW event, the SW PMU
(TYPE_SOFTWARE, TYPE_TRACEPOINT) was added to the per-cpu
rotation_list. That list is used by perf_rotate_context()
to iterate over all the PMUs to rotate event lists and
multiplex.
This is not needed for SW events. Doing this adds some
unnecessary overhead, so drop it by rejecting SW PMUs
in perf_pmu_rotate_start().
Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 7b9df35..40f42b8 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -651,6 +651,10 @@ static void perf_pmu_rotate_start(struct pmu *pmu)
struct perf_cpu_context *cpuctx = this_cpu_ptr(pmu->pmu_cpu_context);
struct list_head *head = &__get_cpu_var(rotation_list);
+ /* no need to mutliplex software events */
+ if (pmu->task_ctx_nr == perf_sw_context)
+ return;
+
WARN_ON(!irqs_disabled());
if (list_empty(&cpuctx->rotation_list))
next reply other threads:[~2012-09-06 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 13:23 Stephane Eranian [this message]
2012-09-06 16:01 ` [PATCH] perf: remove sw events from multiplexing rotation list Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906132346.GA32717@quad \
--to=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox