From: Dave Jones <davej@redhat.com>
To: Eric Paris <eparis@parisplace.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
eparis@redhat.com
Subject: Re: Check all returns from audit_log_start
Date: Thu, 6 Sep 2012 11:56:16 -0400 [thread overview]
Message-ID: <20120906155616.GB27399@redhat.com> (raw)
In-Reply-To: <20120906154749.GA27399@redhat.com>
On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote:
> > Not certain because I haven't looked at what happens with the error
> > code, but I think this might not be right. auditd can be explictly
> > told not to audit certain events, in which case it is normal and
> > expected that ab would come back NULL....
>
> Ugh, that's a lot messier to have to audit every function that gets
> passed 'ab' to make sure it has a NULL check, but ok I'll go look at it.
>
> hopefully audit_log_link_denied was a one off.
ok, from a quick look-over, that does seem to be the case.
This still feels like a nasty trap waiting for someone to walk into again though.
Dave
next prev parent reply other threads:[~2012-09-06 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 13:46 3.6-rc4 audit_log_d_path oops Dave Jones
2012-09-06 15:08 ` Check all returns from audit_log_start Dave Jones
2012-09-06 15:36 ` Eric Paris
2012-09-06 15:47 ` Dave Jones
2012-09-06 15:56 ` Dave Jones [this message]
2012-09-06 15:16 ` 3.6-rc4 audit_log_d_path oops Dave Jones
2012-09-06 15:34 ` Eric Paris
2012-09-06 16:32 ` Kees Cook
2012-09-06 16:45 ` Dave Jones
2012-09-06 17:50 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906155616.GB27399@redhat.com \
--to=davej@redhat.com \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox