From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCH RESEND] USB/host: Cleanup unneccessary irq disable code
Date: Thu, 6 Sep 2012 09:36:13 -0700 [thread overview]
Message-ID: <20120906163613.GA28140@kroah.com> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A178108@SHSMSX101.ccr.corp.intel.com>
On Thu, Sep 06, 2012 at 02:00:16AM +0000, Liu, Chuansheng wrote:
> Because the IRQF_DISABLED as the flag is now a NOOP and has been
> deprecated and in hardirq context the interrupt is disabled.
>
> so in usb/host code:
> Removing the usage of flag IRQF_DISABLED;
> Removing the calling local_irq save/restore actions in irq
> handler usb_hcd_irq();
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> drivers/usb/core/hcd.c | 15 ---------------
> drivers/usb/host/ehci-ls1x.c | 2 +-
> drivers/usb/host/ohci-xls.c | 2 +-
> 3 files changed, 2 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index bc84106..f84ddea 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2153,15 +2153,8 @@ EXPORT_SYMBOL_GPL(usb_bus_start_enum);
> irqreturn_t usb_hcd_irq (int irq, void *__hcd)
> {
> struct usb_hcd *hcd = __hcd;
> - unsigned long flags;
> irqreturn_t rc;
All of your whitespace is broken, making this patch impossible to apply.
As I asked before, please fix this.
greg k-h
next prev parent reply other threads:[~2012-09-06 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 2:00 [PATCH RESEND] USB/host: Cleanup unneccessary irq disable code Liu, Chuansheng
2012-09-06 16:36 ` gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-07 9:19 Chuansheng Liu
2012-09-08 3:26 ` Liu, Chuansheng
2012-09-10 18:08 ` Greg KH
2012-09-10 23:07 ` Liu, Chuansheng
2012-09-11 8:00 Chuansheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906163613.GA28140@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox