Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

Pedro Alves
2012-09-04T22:58:55Z

On 09/04/2012 11:41 PM, Steven Rostedt wrote:
> Ah, I missed the condition with the rec == &pg->records[pg->index]. But
> if ftrace_pages_start is NULL, the rec = &pg->records[pg->index] will
> fault.

Right.

>
> You could do something like rec = pg ? &pg->records[pg->index] : NULL,

Right.

> but IIRC, the comma operator does not guarantee order evaluation. That
> is, the compiler is allowed to process "a , b" as "b; a;" and not "a;
> b;".

Not true. The comma operator introduces a sequence point. It's the comma
that separates function parameters that doesn't guarantee ordering.

--
Pedro Alves