From: Tejun Heo <tj@kernel.org>
To: Kent Overstreet <koverstreet@google.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v10 6/8] block: Kill bi_destructor
Date: Thu, 6 Sep 2012 16:42:42 -0700 [thread overview]
Message-ID: <20120906234242.GA9426@google.com> (raw)
In-Reply-To: <1346970902-10931-7-git-send-email-koverstreet@google.com>
On Thu, Sep 06, 2012 at 03:35:00PM -0700, Kent Overstreet wrote:
> Now that we've got generic code for freeing bios allocated from bio
> pools, this isn't needed anymore.
>
> This patch also makes bio_free() static, since without bi_destructor
> there should be no need for it to be called anywhere else.
>
> bio_free() is now only called from bio_put, so we can refactor those a
> bit - move some code from bio_put() to bio_free() and kill the redundant
> bio->bi_next = NULL.
>
> v5: Switch to BIO_KMALLOC_POOL ((void *)~0), per Boaz
> v6: BIO_KMALLOC_POOL now NULL, drop bio_free's EXPORT_SYMBOL
> v7: No #define BIO_KMALLOC_POOL anymore
>
> Signed-off-by: Kent Overstreet <koverstreet@google.com>
> CC: Jens Axboe <axboe@kernel.dk>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2012-09-06 23:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 22:34 [PATCH v10 0/8] Block cleanups Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 1/8] block: Generalized bio pool freeing Kent Overstreet
2012-09-14 18:28 ` [dm-devel] " Alasdair G Kergon
2012-09-17 20:51 ` Kent Overstreet
2012-09-18 16:31 ` Alasdair G Kergon
2012-09-14 18:36 ` Alasdair G Kergon
2012-09-06 22:34 ` [PATCH v10 2/8] block: Ues bi_pool for bio_integrity_alloc() Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 4/8] block: Add bio_reset() Kent Overstreet
2012-09-07 1:34 ` Jens Axboe
2012-09-07 20:58 ` Kent Overstreet
2012-09-07 21:55 ` Jens Axboe
2012-09-07 22:06 ` Jens Axboe
2012-09-07 22:25 ` Kent Overstreet
2012-09-07 22:44 ` Jens Axboe
2012-09-07 23:14 ` [dm-devel] " Alasdair G Kergon
2012-09-07 23:25 ` Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 5/8] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-09-06 22:35 ` [PATCH v10 6/8] block: Kill bi_destructor Kent Overstreet
2012-09-06 23:42 ` Tejun Heo [this message]
2012-09-06 22:35 ` [PATCH v10 7/8] block: Consolidate bio_alloc_bioset(), bio_kmalloc() Kent Overstreet
2012-09-06 23:45 ` Tejun Heo
2012-09-06 22:35 ` [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc() Kent Overstreet
2012-09-06 23:46 ` Tejun Heo
2012-09-14 21:50 ` [dm-devel] " Alasdair G Kergon
2012-09-17 20:42 ` Kent Overstreet
2012-09-18 16:15 ` Alasdair G Kergon
2012-09-06 23:48 ` [PATCH v10 0/8] Block cleanups Tejun Heo
2012-09-07 1:37 ` Jens Axboe
2012-09-07 20:44 ` Kent Overstreet
2012-09-11 4:43 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906234242.GA9426@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox