From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755536Ab2IGIKj (ORCPT ); Fri, 7 Sep 2012 04:10:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50430 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128Ab2IGIKf (ORCPT ); Fri, 7 Sep 2012 04:10:35 -0400 Date: Fri, 7 Sep 2012 09:10:29 +0100 From: Mel Gorman To: Minchan Kim Cc: Kyungmin Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Michal Nazarewicz , Rik van Riel Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD Message-ID: <20120907081029.GU11266@suse.de> References: <1346832673-12512-1-git-send-email-minchan@kernel.org> <1346832673-12512-2-git-send-email-minchan@kernel.org> <20120905105611.GI11266@suse.de> <20120906053112.GA16231@bbox> <20120906082935.GN11266@suse.de> <20120906090325.GO11266@suse.de> <20120907022601.GH16231@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20120907022601.GH16231@bbox> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 07, 2012 at 11:26:01AM +0900, Minchan Kim wrote: > On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote: > > Hi Mel, > > > > After apply your patch, It got the below message. > > Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA > > + your patch. > > It seems it should not be active but it contains active field. > > Yeb. At the moment, shrink_page_list shouldn't handle active pages > so we should clear PG_active bit in reclaim_clean_pages_from_list. > Yep, that was an obvious thing I missed. It was a very fast prototype to illustrate my point. It should be possible to fix. -- Mel Gorman SUSE Labs