From: Thierry Reding <thierry.reding@avionic-design.de>
To: guanxuetao@mprc.pku.edu.cn
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] unicore32: Add common clock support
Date: Fri, 7 Sep 2012 14:53:28 +0200 [thread overview]
Message-ID: <20120907125328.GB29340@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <63272.162.105.203.8.1346920926.squirrel@mprc.pku.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Thu, Sep 06, 2012 at 04:42:06PM +0800, guanxuetao@mprc.pku.edu.cn wrote:
> > This commit adds support for the common clock framework to the Unicore32
> > architecture.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> This patch can't work.
> Could you disintegrate it into several small patches, so I could check it
> out.
I don't understand. How do you mean it can't work? Are you saying the
patch doesn't build, or does the system no longer boot properly? I don't
see how splitting it into smaller pieces is going to change anything
about that. Splitting it up also isn't going to work very well.
Conversion to the common clock framework is really all or nothing.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-07 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 10:21 [PATCH 0/6] unicore32: Move PWM driver to PWM framework Thierry Reding
2012-09-02 10:21 ` [PATCH 1/6] unicore32: pwm: Properly remap memory-mapped registers Thierry Reding
2012-09-06 8:38 ` guanxuetao
2012-09-07 12:50 ` Thierry Reding
2012-09-02 10:21 ` [PATCH 2/6] unicore32: pwm: Use module_platform_driver() Thierry Reding
2012-09-02 10:21 ` [PATCH 3/6] unicore32: pwm: Remove unnecessary indirection Thierry Reding
2012-09-02 10:21 ` [PATCH 4/6] unicore32: Add common clock support Thierry Reding
2012-09-06 8:42 ` guanxuetao
2012-09-07 12:53 ` Thierry Reding [this message]
2012-09-08 1:22 ` Mike Turquette
2012-09-02 10:21 ` [PATCH 5/6] unicore32: pwm: Use managed resource allocations Thierry Reding
2012-09-02 10:21 ` [PATCH 6/6] pwm: Move PUV3 PWM driver to PWM framework Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907125328.GB29340@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox