[PATCH] regulator: fan53555: remove vsel_max not used

[PATCH] regulator: fan53555: remove vsel_max not used

[Yunfan Zhang]

The max voltage will be bounded by min_uV, uV_step and n_voltages, so
remove it to avoid confusing.

Signed-off-by: Yunfan Zhang <yfzhang@marvell.com>
---
 drivers/regulator/fan53555.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
index 890f2b3..339f4d7 100644
--- a/drivers/regulator/fan53555.c
+++ b/drivers/regulator/fan53555.c
@@ -74,7 +74,6 @@ struct fan53555_device_info {
 	unsigned int sleep_reg;
 	/* Voltage range and step(linear) */
 	unsigned int vsel_min;
-	unsigned int vsel_max;
 	unsigned int vsel_step;
 	/* Voltage slew rate limiting */
 	unsigned int slew_rate;
@@ -180,12 +179,10 @@ static int fan53555_device_setup(struct fan53555_device_info *di,
 	case FAN53555_CHIP_ID_03:
 	case FAN53555_CHIP_ID_05:
 		di->vsel_min = 600000;
-		di->vsel_max = 1230000;
 		di->vsel_step = 10000;
 		break;
 	case FAN53555_CHIP_ID_04:
 		di->vsel_min = 603000;
-		di->vsel_max = 1411000;
 		di->vsel_step = 12826;
 		break;
 	default:
-- 
1.7.0.4

Re: [PATCH] regulator: fan53555: remove vsel_max not used

[Axel Lin]

2012/9/10 Yunfan Zhang <yfzhang@marvell.com>:
> The max voltage will be bounded by min_uV, uV_step and n_voltages, so
> remove it to avoid confusing.
>
> Signed-off-by: Yunfan Zhang <yfzhang@marvell.com>
Acked-by: Axel Lin <axel.lin@gmail.com>

Re: [PATCH] regulator: fan53555: remove vsel_max not used

[Mark Brown]

On Mon, Sep 10, 2012 at 11:53:55AM +0800, Axel Lin wrote:
> 2012/9/10 Yunfan Zhang <yfzhang@marvell.com>:
> > The max voltage will be bounded by min_uV, uV_step and n_voltages, so
> > remove it to avoid confusing.

Applied, thanks.

> Acked-by: Axel Lin <axel.lin@gmail.com>

I think you meant to say Reviewed-by here - Acked mostly just means that
you're OK with the patch being applied, it's not really saying anything
strong about the patch having been properly reviewed.

Re: [PATCH] regulator: fan53555: remove vsel_max not used

[Axel Lin]

2012/9/10 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Mon, Sep 10, 2012 at 11:53:55AM +0800, Axel Lin wrote:
>> 2012/9/10 Yunfan Zhang <yfzhang@marvell.com>:
>> > The max voltage will be bounded by min_uV, uV_step and n_voltages, so
>> > remove it to avoid confusing.
>
> Applied, thanks.
>
>> Acked-by: Axel Lin <axel.lin@gmail.com>
>
> I think you meant to say Reviewed-by here - Acked mostly just means that
Ah.. yes. should be Reviewed-by here.

> you're OK with the patch being applied, it's not really saying anything
> strong about the patch having been properly reviewed.

Thanks for the clarification.
Axel