From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>,
Bryan Wu <bryan.wu@canonical.com>
Subject: Re: [PATCH] leds: add led_trigger_rename function
Date: Mon, 10 Sep 2012 19:57:25 +0200 [thread overview]
Message-ID: <20120910175725.GB2006@gmail.com> (raw)
In-Reply-To: <20120910135535.GA2405@vandijck-laurijssen.be>
On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote:
> On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote:
> > Implements a led_trigger_rename() function to rename a trigger with
> > proper locking.
> This is the way to go.
> Maybe add 'default_trigger' tests? In a later phase?
Do you think that default_trigger should be processed on renames? I
usually think of default_trigger as something just on boot time, but
that could make sense after all.
I think that could go for later phase anyway.
> > This also implies that "name" in "struct led_trigger" is not const
> > anymore.
> IMHO, this is wrong. This forces all other led_triggers
> to put their name in non-const storage.
Uh - is that really a problem?
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2012-09-10 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 15:27 [PATCH] leds: add led_trigger_rename function Fabio Baltieri
2012-09-10 13:55 ` Kurt Van Dijck
2012-09-10 17:57 ` Fabio Baltieri [this message]
2012-09-15 16:15 ` Fabio Baltieri
2012-09-15 16:18 ` [PATCH v2] " Fabio Baltieri
2012-09-23 21:09 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910175725.GB2006@gmail.com \
--to=fabio.baltieri@gmail.com \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox