From: Greg KH <gregkh@linuxfoundation.org>
To: Khalid Aziz <khalid.aziz@hp.com>
Cc: Mike Waychison <mikew@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>, Matthew Garrett <mjg@redhat.com>,
Kees Cook <keescook@chromium.org>,
"gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
khalid@gonehiking.org
Subject: Re: [PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs
Date: Mon, 10 Sep 2012 11:18:55 -0700 [thread overview]
Message-ID: <20120910181855.GA26404@kroah.com> (raw)
In-Reply-To: <1347300789.4393.27.camel@lyra>
On Mon, Sep 10, 2012 at 12:13:09PM -0600, Khalid Aziz wrote:
> On Mon, 2012-09-10 at 11:03 -0700, Greg KH wrote:
> > On Mon, Sep 10, 2012 at 01:59:18PM -0400, Mike Waychison wrote:
> > > On Mon, Sep 10, 2012 at 1:55 PM, Mike Waychison <mikew@google.com> wrote:
> > > > Greg,
> > > >
> > > > Can you please pick this patch up in one of your trees?
> > >
> > > Resend using a good email addy for gregkh :)
> >
> > Can someone resend it in a format that I can apply it in? I can't find
> > the original anymore, sorry.
> >
> > greg k-h
>
> Some of the EFI variable attributes are missing from print out from
> /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also
> updates code to use pre-defined constants for masking current value
> of attributes.
>
> Signed-off-by: Khalid Aziz <khalid.aziz@hp.com>
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index 47408e8..d10c987 100644
This isn't in a format I can apply it in, without having to edit the
heck out of the email by hand :(
Care to try it again, adding the different acks it picked up along the
review way, and send it, again as I asked for, in a format I can apply
it in?
greg k-h
next prev parent reply other threads:[~2012-09-10 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 17:42 [PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs Khalid Aziz
2012-07-13 17:50 ` Matthew Garrett
2012-09-06 17:14 ` Khalid Aziz
2012-09-10 17:55 ` Mike Waychison
2012-09-10 17:59 ` Mike Waychison
2012-09-10 18:03 ` Greg KH
2012-09-10 18:13 ` Khalid Aziz
2012-09-10 18:18 ` Greg KH [this message]
2012-09-10 18:29 ` Khalid Aziz
2012-09-10 18:35 ` Greg KH
2012-09-10 18:52 ` [PATCH v2 RESEND] " Khalid Aziz
2012-09-10 18:58 ` [PATCH v2] " Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910181855.GA26404@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gong.chen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=khalid.aziz@hp.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox