From: Tejun Heo <tj@kernel.org>
To: Kent Overstreet <koverstreet@google.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, axboe@kernel.dk,
Vivek Goyal <vgoyal@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
bharrosh@panasas.com, david@fromorbit.com
Subject: Re: [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers
Date: Mon, 10 Sep 2012 16:13:26 -0700 [thread overview]
Message-ID: <20120910231326.GG7677@google.com> (raw)
In-Reply-To: <20120910220910.GB7677@google.com>
Hello, again.
On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote:
> I'm still a bit scared but think this is correct.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> One last thing is that we may want to add @name on bioset creation so
> that we can name the workqueue properly but that's for another patch.
Yet another thing that I noticed in a different discussion.
http://thread.gmane.org/gmane.linux.network.drbd.devel/2130
Before this, I think bios didn't get reordered while they're traveling
down the stacked bio drivers. After this, I don't think that's true
anymore. Currently, IIRC, we don't have any ordering functionality at
bio interface, so I don't think this breaks anything but this can lead
to stupidly subtle bugs if the upper layer is making assumption on
ordering somehow. It's something which at least should be noted, I
think. Whether we want to update the code so that ordering is
maintained, I don't know. I hope not. It's already crazy complex. :(
Thanks.
--
tejun
next prev parent reply other threads:[~2012-09-10 23:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 22:12 [PATCH 0/2] Avoid deadlocks with bio allocation Kent Overstreet
2012-09-07 22:12 ` [PATCH 1/2] block: Reorder struct bio_set Kent Overstreet
2012-09-07 22:12 ` [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers Kent Overstreet
2012-09-08 19:36 ` Tejun Heo
2012-09-10 0:28 ` Kent Overstreet
2012-09-10 15:25 ` Vivek Goyal
2012-09-10 17:22 ` Tejun Heo
2012-09-10 20:24 ` Kent Overstreet
2012-09-10 20:40 ` Tejun Heo
2012-09-10 21:33 ` Kent Overstreet
2012-09-10 21:37 ` Tejun Heo
2012-09-10 21:56 ` Kent Overstreet
2012-09-10 22:09 ` Tejun Heo
2012-09-10 22:50 ` [dm-devel] " Alasdair G Kergon
2012-09-10 23:01 ` Tejun Heo
2012-09-10 23:06 ` Kent Overstreet
2012-09-10 23:09 ` Alasdair G Kergon
2012-09-10 23:35 ` Tejun Heo
2012-09-10 23:45 ` Alasdair G Kergon
2012-09-10 23:01 ` Kent Overstreet
2012-09-10 23:13 ` Tejun Heo [this message]
2012-09-11 18:36 ` Muthu Kumar
2012-09-11 18:45 ` Tejun Heo
2012-09-11 18:58 ` Muthu Kumar
2012-09-11 19:31 ` Kent Overstreet
2012-09-11 20:00 ` Muthu Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910231326.GG7677@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox