From: Fengguang Wu <fengguang.wu@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
Date: Tue, 11 Sep 2012 08:46:33 +0800 [thread overview]
Message-ID: <20120911004633.GA21147@localhost> (raw)
In-Reply-To: <1347133679-14641-1-git-send-email-andi@firstfloor.org>
On Sat, Sep 08, 2012 at 12:47:59PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> For large kernel configurations (like a distribution kernel)
> targz-pkg takes a quite long time to just do the compression.
> I clocked it at 15+mins for a SUSE kernel like config on a fast
> system. And tarxz and bzip2 are even slower.
>
> The main reason is that the script that is doing the taring sets
> the highest compression level (-9). When I change it to just
> use the defaults the gzip time for the same kernel goes down
> to ~3 mins. I haven't tested xz and bzip, but I expect those
> to be much faster too.
>
> I'm not willing to wait that long for a small compression
> gain. So just change the script to use the defaults.
Makes sense to me.
Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> scripts/package/buildtar | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8a7b155..632377f 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -28,15 +28,15 @@ case "${1}" in
> file_ext=""
> ;;
> targz-pkg)
> - compress="gzip -c9"
> + compress="gzip"
-c should be kept because it means --stdout and --keep
> file_ext=".gz"
> ;;
> tarbz2-pkg)
> - compress="bzip2 -c9"
> + compress="bzip2"
ditto
> file_ext=".bz2"
> ;;
> tarxz-pkg)
> - compress="xz -c9"
> + compress="xz"
ditto
> file_ext=".xz"
> ;;
> *)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-09-11 0:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 19:47 [PATCH] Kbuild: use normal compression settings for tar*-pkg Andi Kleen
2012-09-11 0:46 ` Fengguang Wu [this message]
2012-09-11 3:01 ` Andi Kleen
2012-09-11 4:21 ` Fengguang Wu
2012-09-27 15:06 ` Michal Marek
2012-09-12 16:01 ` Zdenek Kaspar
2012-09-12 16:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911004633.GA21147@localhost \
--to=fengguang.wu@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox