Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info(...

Greg KH
2012-09-11T02:52:59Z

On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
>
> Signed-off-by: Bruce Humphrey Ventura <brucehum@gmail.com>
> ---
> drivers/staging/comedi/drivers/fl512.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> index d1da809..258a7b4 100644
> --- a/drivers/staging/comedi/drivers/fl512.c
> +++ b/drivers/staging/comedi/drivers/fl512.c
> @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> struct comedi_subdevice *s;
>
> iobase = it->options[0];
> - printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> + pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);

Why can't you use dev_info() here, and in other places? You should use
the dev_* functions instead of pr_* wherever possible.

thanks,

greg k-h