From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
"HACHIMI Samir" <shachimi@adeneo-embedded.com>,
shawn.guo@linaro.org, linux-kernel@vger.kernel.org,
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>,
kernel@pengutronix.de, "Philipp Zabel" <p.zabel@pengutronix.de>
Subject: Re: [PATCH 5/7] pwm: i.MX: add devicetree support
Date: Tue, 11 Sep 2012 16:40:43 +0200 [thread overview]
Message-ID: <20120911144043.GA3824@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1347267577-3296-6-git-send-email-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
On Mon, Sep 10, 2012 at 10:59:35AM +0200, Sascha Hauer wrote:
> From: Philipp Zabel <p.zabel@pengutronix.de>
>
> At the same time remove platform based support. No user for
> this driver has made it into mainline so far, so all we break
> is out of tree stuff.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Shawn Guo <shawn.guo@linaro.org>
> Reviewed-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
[...]
I was just doing some build tests on the series and noticed that it
fails with this:
CC [M] drivers/pwm/pwm-imx.o
/home/thierry.reding/src/kernel/linux-pwm.git/drivers/pwm/pwm-imx.c: In function 'imx_pwm_config_v2':
/home/thierry.reding/src/kernel/linux-pwm.git/drivers/pwm/pwm-imx.c:140:2: error: implicit declaration of function 'cpu_is_mx25' [-Werror=implicit-function-declaration]
This breaks bisection in the middle of the series. It seems to be
related to this change.
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index a1e799e..b4e0ad3 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -16,8 +16,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/pwm.h>
> -#include <mach/hardware.h>
This probably needs to be postponed to the next patch, until the final
reference to cpu_is_mx25() is removed.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-11 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 8:59 [PATCH v4] pwm: i.MX: add devicetree support Sascha Hauer
2012-09-10 8:59 ` [PATCH 1/7] pwm: i.MX: factor out SoC specific functions Sascha Hauer
2012-09-10 8:59 ` [PATCH 2/7] pwm: i.MX: remove unnecessary if in pwm_[en|dis]able Sascha Hauer
2012-09-10 8:59 ` [PATCH 3/7] pwm: i.MX: add functions to enable/disable pwm Sascha Hauer
2012-09-10 8:59 ` [PATCH 4/7] pwm: i.MX: Use module_platform_driver Sascha Hauer
2012-09-10 8:59 ` [PATCH 5/7] pwm: i.MX: add devicetree support Sascha Hauer
2012-09-11 14:40 ` Thierry Reding [this message]
2012-09-12 9:04 ` Sascha Hauer
2012-09-18 6:11 ` Thierry Reding
2012-09-18 7:57 ` Sascha Hauer
2012-09-10 8:59 ` [PATCH 6/7] pwm: i.MX: use per clock unconditionally Sascha Hauer
2012-09-10 8:59 ` [PATCH 7/7] pwm: i.MX: fix clock lookup Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911144043.GA3824@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=benoit.thebaudeau@advansee.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shachimi@adeneo-embedded.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox