Re: [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

Tejun Heo
2012-09-10T23:13:32Z

Hello, again.

On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote:
> I'm still a bit scared but think this is correct.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> One last thing is that we may want to add @name on bioset creation so
> that we can name the workqueue properly but that's for another patch.

Yet another thing that I noticed in a different discussion.

http://thread.gmane.org/gmane.linux.network.drbd.devel/2130

Before this, I think bios didn't get reordered while they're traveling
down the stacked bio drivers. After this, I don't think that's true
anymore. Currently, IIRC, we don't have any ordering functionality at
bio interface, so I don't think this breaks anything but this can lead
to stupidly subtle bugs if the upper layer is making assumption on
ordering somehow. It's something which at least should be noted, I
think. Whether we want to update the code so that ordering is
maintained, I don't know. I hope not. It's already crazy complex. :(

Thanks.

--
tejun