public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [GIT PULL] workqueue fixes for 3.6-rc5
Date: Tue, 11 Sep 2012 15:24:16 -0700	[thread overview]
Message-ID: <20120911222416.GI7677@google.com> (raw)

Hello, Linus.

Please consider pulling from the following branch to receive workqueue
fixes.  It's later than I'd like but well the timing just didn't work
out this time.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-3.6-fixes

There are three bug fixes.  One from before 3.6-rc1 and two from the
new CPU hotplug code.  Kudos to Lai for discovering all of them and
providing fixes.

* Atomicity bug when clearing a flag and setting another.  The two
  operation should have been atomic but wasn't.  This bug has existed
  for a long time but is unlikely to have actually happened.  Fix is
  safe.  Marked for -stable.

* If CPU hotplug cycles happen back-to-back before workers finish the
  previous cycle, the states could get out of sync and it could get
  stuck.  Fixed by waiting for workers to complete before finishing
  hotplug cycle.

* While CPU hotplug is in progress, idle workers could be depleted
  which can then lead to deadlock.  I think both happening together is
  highly unlikely but still better to fix it and the fix isn't too
  scary.

Lai Jiangshan (3):
      workqueue: UNBOUND -> REBIND morphing in rebind_workers() should be atomic
      workqueue: restore POOL_MANAGING_WORKERS
      workqueue: fix possible idle worker depletion across CPU hotplug

Tejun Heo (2):
      workqueue: move WORKER_REBIND clearing in rebind_workers() to the end of the function
      workqueue: fix possible deadlock in idle worker rebinding

 kernel/workqueue.c |  110 ++++++++++++++++++++++++++++++++++++++++++----------
 1 files changed, 89 insertions(+), 21 deletions(-)

Thanks.

--
tejun

             reply	other threads:[~2012-09-11 22:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 22:24 Tejun Heo [this message]
2012-09-11 22:28 ` [GIT PULL] workqueue fixes for 3.6-rc5 Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911222416.GI7677@google.com \
    --to=tj@kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox