From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550Ab2IKWnm (ORCPT ); Tue, 11 Sep 2012 18:43:42 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:51240 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502Ab2IKWnl (ORCPT ); Tue, 11 Sep 2012 18:43:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgwKAJW9T1B5LPyM/2dsb2JhbABFulADgQSBCIIgAQEEATocIwULCAMVAy4UDRgDFh6HfgMJBbJMDYlTFIoZY26CGYI/YAOUCoFUixaFCIJ4 Date: Wed, 12 Sep 2012 08:43:37 +1000 From: Dave Chinner To: raghu.prabhu13@gmail.com Cc: xfs@oss.sgi.com, Raghavendra D Prabhu , Ben Myers , Alex Elder , open list Subject: Re: [PATCH 1/3] Add ratelimited printk for different alert levels Message-ID: <20120911224337.GF11511@dastard> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 12, 2012 at 03:43:22AM +0530, raghu.prabhu13@gmail.com wrote: > From: Raghavendra D Prabhu > > Ratelimited printk will be useful in printing xfs messages which are otherwise > not required to be printed always due to their high rate (to prevent kernel ring > buffer from overflowing), while at the same time required to be printed. > > Signed-off-by: Raghavendra D Prabhu > --- > fs/xfs/xfs_message.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h > index 56dc0c1..87999a5 100644 > --- a/fs/xfs/xfs_message.h > +++ b/fs/xfs/xfs_message.h > @@ -1,6 +1,8 @@ > #ifndef __XFS_MESSAGE_H > #define __XFS_MESSAGE_H 1 > > +#include > + Include this in xfs_linux.h rather than here. > struct xfs_mount; > > extern __printf(2, 3) > @@ -30,6 +32,32 @@ void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...) > } > #endif > > +#define xfs_printk_ratelimited(xfs_printk, dev, fmt, ...) \ > +do { \ > + static DEFINE_RATELIMIT_STATE(_rs, \ > + DEFAULT_RATELIMIT_INTERVAL, \ > + DEFAULT_RATELIMIT_BURST); \ > + if (__ratelimit(&_rs)) \ > + xfs_printk(dev, fmt, ##__VA_ARGS__); \ > +} while (0) Use "func" not xfs_printk here. xfs_printk looks too much like a real function name (indeed, we already have __xfs_printk) rather than a macro parameter. > +#define xfs_emerg_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_emerg, dev, fmt, ##__VA_ARGS__) > +#define xfs_alert_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_alert, dev, fmt, ##__VA_ARGS__) > +#define xfs_crit_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_crit, dev, fmt, ##__VA_ARGS__) > +#define xfs_err_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_err, dev, fmt, ##__VA_ARGS__) > +#define xfs_warn_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_warn, dev, fmt, ##__VA_ARGS__) > +#define xfs_notice_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_notice, dev, fmt, ##__VA_ARGS__) > +#define xfs_info_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_info, dev, fmt, ##__VA_ARGS__) > +#define xfs_dbg_ratelimited(dev, fmt, ...) \ > + xfs_printk_ratelimited(xfs_dbg, dev, fmt, ##__VA_ARGS__) Here's the problem with adding macros that aren't used. xfs_dbg does not exist - the function is xfs_debug(). The compiler won't catch that until the macro is used, so only add the macros which are needed for this patch series. Cheers, Dave. -- Dave Chinner david@fromorbit.com