From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/media: Removes useless kfree()
Date: Wed, 12 Sep 2012 11:06:42 +0300 [thread overview]
Message-ID: <20120912080642.GA19396@mwanda> (raw)
In-Reply-To: <1347386432-12954-1-git-send-email-peter.senna@gmail.com>
On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
> diff --git a/drivers/media/dvb-frontends/lg2160.c b/drivers/media/dvb-frontends/lg2160.c
> index cc11260..748da5d 100644
> --- a/drivers/media/dvb-frontends/lg2160.c
> +++ b/drivers/media/dvb-frontends/lg2160.c
> @@ -1451,7 +1451,6 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config,
> return &state->frontend;
> fail:
> lg_warn("unable to detect LG216x hardware\n");
> - kfree(state);
> return NULL;
> }
I wish you had fixed this the same as the others and removed the
goto. Also the printk is redundant and wrong. Remove it too.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-12 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 18:00 [PATCH] drivers/media: Removes useless kfree() Peter Senna Tschudin
2012-09-11 18:24 ` Marcos Souza
2012-09-12 8:06 ` Dan Carpenter [this message]
2012-09-12 12:45 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912080642.GA19396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox