From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755054Ab2ILI0x (ORCPT ); Wed, 12 Sep 2012 04:26:53 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:17584 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753347Ab2ILI0t (ORCPT ); Wed, 12 Sep 2012 04:26:49 -0400 Date: Wed, 12 Sep 2012 11:26:39 +0300 From: Dan Carpenter To: Eduardo Valentin Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, b-cousson@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings Message-ID: <20120912082639.GI19410@mwanda> References: <1347379615-6881-1-git-send-email-eduardo.valentin@ti.com> <1347379615-6881-2-git-send-email-eduardo.valentin@ti.com> <20120912081127.GB19396@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120912081127.GB19396@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote: > On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote: > > From: J Keerthy > > > > Removes checkpatch warnings on omap-bandgap.c. > > > > Which checkpatch.pl warnings? > > > + omap_bandgap_writel(bg_ptr, > > + rval->tshut_threshold, > > + tsr->tshut_threshold); > > That's just whacky. > > Personally, I've never cared much about long lines, so I'd prefer > to leave these as is until someone can break the functions up and > remove them in a proper way instead of just shifting everything > randomly to the left. > Sorry, that was my default response without looking at the code. This is already broken up into small functions pretty nicely. You might want to consider using shorter names. For example omap_bandgap_writel() could be changed to "obg_writel()" and "bg_ptr" could be changed to just "bg" because it's obviously a pointer. regards, dan carpenter