From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: devel@driverdev.osuosl.org, Martyn Welch <martyn.welch@ge.com>,
Manohar Vanga <manohar.vanga@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging/vme: Use pr_ printks in vme_user.c
Date: Wed, 12 Sep 2012 07:04:48 -0700 [thread overview]
Message-ID: <20120912140448.GA3531@kroah.com> (raw)
In-Reply-To: <CAOTypNRQn+yTH8jkDf2u+DAV42HM-igrxS4JO2NLu2U2PgS_7Q@mail.gmail.com>
On Wed, Sep 12, 2012 at 04:36:19PM +0900, Toshiaki Yamane wrote:
> On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote:
> >> The below checkpatch warnings was fixed,
> >>
> >> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
> >> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> >> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
> >
> > A lot of these can be using dev_* instead of the pr_* functions, right?
> > Please convert to using them wherever possible.
> >
> > Because of that, I can't take this patch, sorry. Care to redo it?
>
> Yes. Is this collect?
"correct"?
> I must use dev_* procedure when the following conditions are met:
> - If I have access to struct device object by the argument of the procedure
> - Except for the right: struct net_device, etc.
>
> Otherwise, I must use pr_* procedure.
Yes, that is correct :)
greg k-h
next prev parent reply other threads:[~2012-09-12 14:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 13:00 [PATCH] staging/vme: fix checkpatch warnings Toshiaki Yamane
2012-07-23 0:53 ` Toshiaki Yamane
2012-08-17 5:04 ` [PATCH 1/5] staging/vme: fix checkpatch error Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 2/5] staging/vme: fix checkpatch warning Toshiaki Yamane
2012-08-17 7:46 ` Dan Carpenter
2012-08-17 8:27 ` Toshiaki Yamane
2012-08-17 13:19 ` Greg Kroah-Hartman
2012-08-17 14:30 ` Toshiaki Yamane
2012-08-21 11:11 ` Toshiaki Yamane
2012-08-21 11:12 ` [PATCH 1/3] Staging: vme: Fix a white space issue Toshiaki Yamane
2012-08-21 11:12 ` [PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c Toshiaki Yamane
2012-09-04 20:20 ` Greg Kroah-Hartman
2012-09-11 7:16 ` [PATCH 1/2] " Toshiaki Yamane
2012-09-11 7:17 ` [PATCH 2/2] staging/vme: Use dev_ " Toshiaki Yamane
2012-09-11 19:08 ` Greg Kroah-Hartman
2012-09-11 19:08 ` [PATCH 1/2] staging/vme: Use pr_ " Greg Kroah-Hartman
2012-09-12 7:36 ` Toshiaki Yamane
2012-09-12 14:04 ` Greg Kroah-Hartman [this message]
2012-08-21 11:13 ` [PATCH 3/3] staging/vme: Use pr_ printks in vme_pio2_core.c Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 3/5] staging/vme: fix checkpatch warning Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 4/5] " Toshiaki Yamane
2012-08-17 5:06 ` [PATCH 5/5] " Toshiaki Yamane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912140448.GA3531@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox